ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm - Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier (Closed)

Patch Set: Cleanup Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/collection_view/collection_view_model.h ('K') | « ios/chrome/browser/ui/settings/block_popups_collection_view_controller.mm ('k') | ios/chrome/browser/ui/settings/content_settings_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

diff --git a/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm b/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

index 1a128bd23d510829a4a69452d2909b5e69cb4c77..8de8c2dc6c0468aca88d6b5181e2497dbf71dcb7 100644

--- a/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

+++ b/ios/chrome/browser/ui/settings/clear_browsing_data_collection_view_controller.mm

@@ -410,8 +410,7 @@ const int kMaxTimesHistoryNoticeShown = 1;

return;

}

clearDataItem.detailText = detailText;

- [self reconfigureCellsForItems:@[ clearDataItem ]

- inSectionWithIdentifier:SectionIdentifierDataTypes];

+ [self reconfigureCellsForItems:@[ clearDataItem ]];

[self.collectionView.collectionViewLayout invalidateLayout];

}

@@ -537,8 +536,7 @@ const int kMaxTimesHistoryNoticeShown = 1;

[self updateCounter:itemType detailText:nil];

}

- [self reconfigureCellsForItems:@[ clearDataItem ]

- inSectionWithIdentifier:SectionIdentifierDataTypes];

+ [self reconfigureCellsForItems:@[ clearDataItem ]];

break;

}

case ItemTypeClearBrowsingDataButton:

@@ -585,8 +583,7 @@ const int kMaxTimesHistoryNoticeShown = 1;

// Add the new footer.

[model addItem:footerItem

toSectionWithIdentifier:SectionIdentifierGoogleAccount];

- [self reconfigureCellsForItems:@[ footerItem ]

- inSectionWithIdentifier:SectionIdentifierGoogleAccount];

+ [self reconfigureCellsForItems:@[ footerItem ]];

// Relayout the cells to adapt to the new contents height.

[self.collectionView.collectionViewLayout invalidateLayout];