ios/chrome/browser/ui/payments/payment_request_view_controller.mm - Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/payments/payment_request_view_controller.mm

Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier (Closed)

Patch Set: Cleanup Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ios/chrome/browser/ui/collection_view/collection_view_model.h ('K') | « ios/chrome/browser/ui/payments/payment_request_selector_view_controller.mm ('k') | ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/payments/payment_request_view_controller.mm

diff --git a/ios/chrome/browser/ui/payments/payment_request_view_controller.mm b/ios/chrome/browser/ui/payments/payment_request_view_controller.mm

index 52797706b8df2be58a082f1580762cc00def7bf1..773752a0bf47acc506eaf22ac258b032558672f0 100644

--- a/ios/chrome/browser/ui/payments/payment_request_view_controller.mm

+++ b/ios/chrome/browser/ui/payments/payment_request_view_controller.mm

@@ -408,8 +408,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

withPaymentItem:_paymentRequest->payment_details().total

withTotalValueChanged:totalValueChanged];

NSIndexPath* indexPath =

- [self.collectionViewModel indexPathForItem:_paymentSummaryItem

- inSectionWithIdentifier:SectionIdentifierSummary];

+ [self.collectionViewModel indexPathForItem:_paymentSummaryItem];

[self.collectionView reloadItemsAtIndexPaths:@[ indexPath ]];

}

@@ -417,8 +416,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

[self fillShippingAddressItem:_selectedShippingAddressItem

withAutofillProfile:_paymentRequest->selected_shipping_profile()];

NSIndexPath* indexPath =

- [self.collectionViewModel indexPathForItem:_selectedShippingAddressItem

- inSectionWithIdentifier:SectionIdentifierShipping];

+ [self.collectionViewModel indexPathForItem:_selectedShippingAddressItem];

[self.collectionView reloadItemsAtIndexPaths:@[ indexPath ]];

}

@@ -426,8 +424,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

[self fillShippingOptionItem:_selectedShippingOptionItem

withOption:_paymentRequest->selected_shipping_option()];

NSIndexPath* indexPath =

- [self.collectionViewModel indexPathForItem:_selectedShippingOptionItem

- inSectionWithIdentifier:SectionIdentifierShipping];

+ [self.collectionViewModel indexPathForItem:_selectedShippingOptionItem];

[self.collectionView reloadItemsAtIndexPaths:@[ indexPath ]];

}

@@ -435,8 +432,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

[self fillPaymentMethodItem:_selectedPaymentMethodItem

withCreditCard:_paymentRequest->selected_credit_card()];

NSIndexPath* indexPath =

- [self.collectionViewModel indexPathForItem:_selectedPaymentMethodItem

- inSectionWithIdentifier:SectionIdentifierPayment];

+ [self.collectionViewModel indexPathForItem:_selectedPaymentMethodItem];

[self.collectionView reloadItemsAtIndexPaths:@[ indexPath ]];

}