Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm

Issue 2761263003: Allow CollectionViewModel/Controller queries without SectionIdentifier (Closed)
Patch Set: Cleanup Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm
diff --git a/ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm b/ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm
index 0ae51f2be05803ed275eb7ff04ebaa8b2045749f..1f1144b8f1ab73530d0e04e789db0dca42012631 100644
--- a/ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm
+++ b/ios/chrome/browser/ui/collection_view/collection_view_model_unittest.mm
@@ -522,16 +522,21 @@ TEST(CollectionViewModelTest, IndexPathsForItems) {
toSectionWithIdentifier:SectionIdentifierWeasley];
[model addItemWithType:ItemTypeWeasleyArthur
toSectionWithIdentifier:SectionIdentifierWeasley];
+ // Item not added.
+ CollectionViewItem* notAddedItem =
+ [[CollectionViewItem alloc] initWithType:ItemTypeCheeseGouda];
- NSIndexPath* indexPath1 = [model indexPathForItem:item1
- inSectionWithIdentifier:SectionIdentifierWeasley];
+ EXPECT_TRUE([model hasItem:item1]);
+ NSIndexPath* indexPath1 = [model indexPathForItem:item1];
EXPECT_EQ(0, indexPath1.section);
EXPECT_EQ(1, indexPath1.item);
- NSIndexPath* indexPath4 = [model indexPathForItem:item4
- inSectionWithIdentifier:SectionIdentifierWeasley];
+ EXPECT_TRUE([model hasItem:item4]);
+ NSIndexPath* indexPath4 = [model indexPathForItem:item4];
EXPECT_EQ(0, indexPath4.section);
EXPECT_EQ(4, indexPath4.item);
+
+ EXPECT_FALSE([model hasItem:notAddedItem]);
}
TEST(CollectionViewModelTest, Headers) {

Powered by Google App Engine
This is Rietveld 408576698