Allow CollectionViewModel/Controller queries without SectionIdentifier

ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.h"
 
 #include <memory>
 
 #include "base/auto_reset.h"
 #include "base/mac/foundation_util.h"
@@ skipping 705 matching lines @@
 }
 
 - (void)updateCollectionViewInternal {
   NSIndexPath* indexPath = [self.collectionViewModel
       indexPathForItemType:ItemTypeSyncSwitch
          sectionIdentifier:SectionIdentifierEnableSync];
 
   SyncSwitchItem* syncItem = base::mac::ObjCCastStrict<SyncSwitchItem>(
       [self.collectionViewModel itemAtIndexPath:indexPath]);
   syncItem.on = _syncSetupService->IsSyncEnabled();
-  [self reconfigureCellsForItems:@[ syncItem ]
-         inSectionWithIdentifier:SectionIdentifierEnableSync];
+  [self reconfigureCellsForItems:@[ syncItem ]];
 
   // Update Sync Accounts section.
   if ([self hasAccountsSection]) {
     NSInteger section = [self.collectionViewModel
         sectionForSectionIdentifier:SectionIdentifierSyncAccounts];
     NSInteger itemsCount =
         [self.collectionViewModel numberOfItemsInSection:section];
     NSMutableArray* accountsToReconfigure =
         [[[NSMutableArray alloc] init] autorelease];
     for (NSInteger item = 0; item < itemsCount; ++item) {
       NSIndexPath* indexPath = [self.collectionViewModel
           indexPathForItemType:ItemTypeAccount
              sectionIdentifier:SectionIdentifierSyncAccounts
                        atIndex:item];
       CollectionViewAccountItem* accountItem =
           base::mac::ObjCCastStrict<CollectionViewAccountItem>(
               [self.collectionViewModel itemAtIndexPath:indexPath]);
       accountItem.enabled = _syncSetupService->IsSyncEnabled();
       [accountsToReconfigure addObject:accountItem];
     }
-    [self reconfigureCellsForItems:accountsToReconfigure
-           inSectionWithIdentifier:SectionIdentifierSyncAccounts];
+    [self reconfigureCellsForItems:accountsToReconfigure];
   }
 
   // Update Sync Services section.
   indexPath = [self.collectionViewModel
       indexPathForItemType:ItemTypeSyncEverything
          sectionIdentifier:SectionIdentifierSyncServices];
   SyncSwitchItem* syncEverythingItem =
       base::mac::ObjCCastStrict<SyncSwitchItem>(
           [self.collectionViewModel itemAtIndexPath:indexPath]);
   syncEverythingItem.on = _syncSetupService->IsSyncingAllDataTypes();
   syncEverythingItem.enabled = [self shouldSyncEverythingItemBeEnabled];
-  [self reconfigureCellsForItems:@[ syncEverythingItem ]
-         inSectionWithIdentifier:SectionIdentifierSyncServices];
+  [self reconfigureCellsForItems:@[ syncEverythingItem ]];
 
   NSInteger section = [self.collectionViewModel
       sectionForSectionIdentifier:SectionIdentifierSyncServices];
   NSInteger itemsCount =
       [self.collectionViewModel numberOfItemsInSection:section];
   // Syncable data types cells are offset by the Sync Everything cell.
   NSMutableArray* switchsToReconfigure =
       [[[NSMutableArray alloc] init] autorelease];
   for (NSInteger item = 1; item < itemsCount; ++item) {
     NSUInteger index = item - 1;
     NSIndexPath* indexPath = [self.collectionViewModel
         indexPathForItemType:ItemTypeSyncableDataType
            sectionIdentifier:SectionIdentifierSyncServices
                      atIndex:index];
     SyncSwitchItem* syncSwitchItem = base::mac::ObjCCastStrict<SyncSwitchItem>(
         [self.collectionViewModel itemAtIndexPath:indexPath]);
     SyncSetupService::SyncableDatatype dataType =
         (SyncSetupService::SyncableDatatype)syncSwitchItem.dataType;
     syncer::ModelType modelType = _syncSetupService->GetModelType(dataType);
     syncSwitchItem.on = _syncSetupService->IsDataTypeEnabled(modelType);
     syncSwitchItem.enabled = [self shouldSyncableItemsBeEnabled];
     [switchsToReconfigure addObject:syncSwitchItem];
   }
-  [self reconfigureCellsForItems:switchsToReconfigure
-         inSectionWithIdentifier:SectionIdentifierSyncServices];
+  [self reconfigureCellsForItems:switchsToReconfigure];
 
   // Update Encryption cell.
   [self updateEncryptionCell];
 
   // Add/Remove the Sync Error. This is the only update that can change index
   // paths. It is done last because self.collectionViewModel isn't aware of
   // the performBatchUpdates:completion: order of update/remove/delete.
   [self updateSyncError];
 }
 
@@ skipping 22 matching lines @@
 
 - (void)updateEncryptionCell {
   BOOL shouldDisplayEncryptionError = [self shouldDisplayEncryptionError];
   NSIndexPath* indexPath = [self.collectionViewModel
       indexPathForItemType:ItemTypeEncryption
          sectionIdentifier:SectionIdentifierEncryptionAndFooter];
   TextAndErrorItem* item = base::mac::ObjCCastStrict<TextAndErrorItem>(
       [self.collectionViewModel itemAtIndexPath:indexPath]);
   item.shouldDisplayError = shouldDisplayEncryptionError;
   item.enabled = [self shouldEncryptionItemBeEnabled];
-  [self reconfigureCellsForItems:@[ item ]
-         inSectionWithIdentifier:SectionIdentifierEncryptionAndFooter];
+  [self reconfigureCellsForItems:@[ item ]];
 }
 
 - (void)updateAccountItem:(CollectionViewAccountItem*)item
              withIdentity:(ChromeIdentity*)identity {
   item.image = [_avatarCache resizedAvatarForIdentity:identity];
   item.text = identity.userEmail;
   item.chromeIdentity = identity;
 }
 
 #pragma mark Helpers
@@ skipping 116 matching lines @@
   [_authenticationFlow cancelAndDismiss];
 }
 
 #pragma mark - ChromeIdentityServiceObserver
 
 - (void)onProfileUpdate:(ChromeIdentity*)identity {
   CollectionViewAccountItem* item =
       base::mac::ObjCCastStrict<CollectionViewAccountItem>(
           [_identityMap objectForKey:identity.gaiaID]);
   [self updateAccountItem:item withIdentity:identity];
-  [self reconfigureCellsForItems:@[ item ]
-         inSectionWithIdentifier:SectionIdentifierSyncAccounts];
+  [self reconfigureCellsForItems:@[ item ]];
 }
 
 - (void)onChromeIdentityServiceWillBeDestroyed {
   _identityServiceObserver.reset();
 }
 
 @end