Add a unit tests for RenderText::FindCursorPosition.

Add a unit tests for RenderText::FindCursorPosition.

Verifies that FindCursorPosition works with GetGlyphBounds values.

Prompted by a question reviewing Cem's WIP RenderTextHarfBuzz:
https://codereview.chromium.org/152473008/diff/100001/ui/gfx/render_text_harfbuzz.cc#newcode787
I thought RenderTextWin::GetRunContainingXCoord needed visual run order.
Logical run order is fine as-is, because it checks the range of x bounds.
(RenderTextHarfBuzz should probably do the same thing to be safe/correct)

BUG=NONE
TEST=NONE
R=asvitkine@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269941

[msw, 2014-05-10 05:21:30]

Hey Alexei, please take a look; thanks!
Cem, please take note for RenderTextHarfBuzz.

[Alexei Svitkine (slow), 2014-05-12 15:23:26]

https://codereview.chromium.org/276123003/diff/10001/ui/gfx/render_text_unitt...
File ui/gfx/render_text_unittest.cc (right):

https://codereview.chromium.org/276123003/diff/10001/ui/gfx/render_text_unitt...
ui/gfx/render_text_unittest.cc:956: render_text->EnsureLayout();
GetGlyphBounds() and FindCursorPosition() are both public methods.

So you shouldn't need to call the protected EnsureLayout() method here before
calling those. If this currently causes a crash/dcheck, than that's a bug and
should be fixed.

After you remove the EnsureLayout() call, I think you should also be able to
remove the friend test declaration for this test, since it will be using public
methods only.

[msw, 2014-05-12 17:15:56]

Done, please take another look; thanks!

https://codereview.chromium.org/276123003/diff/10001/ui/gfx/render_text_unitt...
File ui/gfx/render_text_unittest.cc (right):

https://codereview.chromium.org/276123003/diff/10001/ui/gfx/render_text_unitt...
ui/gfx/render_text_unittest.cc:956: render_text->EnsureLayout();
On 2014/05/12 15:23:27, Alexei Svitkine wrote:
> GetGlyphBounds() and FindCursorPosition() are both public methods.
> 
> So you shouldn't need to call the protected EnsureLayout() method here before
> calling those. If this currently causes a crash/dcheck, than that's a bug and
> should be fixed.
> 
> After you remove the EnsureLayout() call, I think you should also be able to
> remove the friend test declaration for this test, since it will be using
public
> methods only.

Done.

[Alexei Svitkine (slow), 2014-05-12 17:17:41]

LGTM, thanks!

[msw, 2014-05-12 17:18:32]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2014-05-12 17:19:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/msw@chromium.org/276123003/30001

[commit-bot: I haz the power, 2014-05-12 20:46:44]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-13 00:50:53]

Change committed as 269941