ios/web/web_state/ui/web_view_js_utils.h - Issue 2761173002: Disallow JS execution on WebUI pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/web_state/ui/web_view_js_utils.h

Issue 2761173002: Disallow JS execution on WebUI pages. (Closed)

Patch Set: Addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/web_state/ui/web_view_js_utils.h

diff --git a/ios/web/web_state/ui/web_view_js_utils.h b/ios/web/web_state/ui/web_view_js_utils.h

index 39c5d8e6ad646a548dda39c55fc68f73250cc1dd..a165ccb22c64b630632c8b86f64faae3d4ba9a00 100644

--- a/ios/web/web_state/ui/web_view_js_utils.h

+++ b/ios/web/web_state/ui/web_view_js_utils.h

@@ -27,7 +27,9 @@ extern int const kMaximumParsingRecursionDepth;

// The type of errors that can occur while evaluating JS.

enum JSEvaluationErrorCode {

// No web view present to evaluate JS.

- JS_EVALUATION_ERROR_CODE_NO_WEB_VIEW = 1,

+ JS_EVALUATION_ERROR_CODE_NO_WEB_VIEW = -1000,

+ // JS evaluation is not allowed for security reasons.

+ JS_EVALUATION_ERROR_CODE_REJECTED = -1001,

};

// Converts result of WKWebView script evaluation to base::Value.

« no previous file with comments | « ios/web/web_state/ui/crw_web_controller_unittest.mm ('k') | no next file » | no next file with comments »