Disallow JS execution on WebUI pages.

ios/chrome/browser/ui/toolbar/toolbar_egtest.mm

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import <EarlGrey/EarlGrey.h>
 #import <XCTest/XCTest.h>
 
 #include "base/ios/ios_util.h"
 #include "components/strings/grit/components_strings.h"
 #import "ios/chrome/browser/ui/commands/generic_chrome_command.h"
@@ skipping 322 matching lines @@
   [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
       assertWithMatcher:chrome_test_util::OmniboxText("")];
 }
 
 // Types JavaScript into Omnibox and verify that an alert is displayed.
 - (void)testTypeJavaScriptIntoOmnibox {
   // TODO(crbug.com/642544): Enable the test for iPad when typing bug is fixed.
   if (IsIPadIdiom() && base::ios::IsRunningOnIOS10OrLater()) {
     EARL_GREY_TEST_DISABLED(@"Disabled for iOS10 iPad due to a typing bug.");
   }
-  [ChromeEarlGrey loadURL:GURL("chrome://version")];
+
+  std::map<GURL, std::string> responses;
+  GURL URL = web::test::HttpServer::MakeUrl("http://foo");
+  responses[URL] = "bar";
+  web::test::SetUpSimpleHttpServer(responses);
+  [ChromeEarlGrey loadURL:GURL(URL)];
+
   [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
       performAction:grey_typeText(@"javascript:alert('Hello');")];
 
   [[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Go")]
       performAction:grey_tap()];
 
   [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(@"Hello")]
       assertWithMatcher:grey_notNil()];
 }
 
+// Loads WebUI page, types JavaScript into Omnibox and verify that alert is not

[lpromero, 2017/03/23 12:43:48]

Nit: verifies

[Eugene But (OOO till 7-30), 2017/03/23 17:45:08]

Done.

+// displayed. WebUI pages have elevated previledges and should not allow script

[lpromero, 2017/03/23 12:43:48]

Nit: privileges

[Eugene But (OOO till 7-30), 2017/03/23 17:45:08]

Done.

+// execution.
+- (void)testTypeJavaScriptIntoOmniboxWithWebUIPage {
+  // TODO(crbug.com/642544): Enable the test for iPad when typing bug is fixed.
+  if (IsIPadIdiom() && base::ios::IsRunningOnIOS10OrLater()) {
+    EARL_GREY_TEST_DISABLED(@"Disabled for iOS10 iPad due to a typing bug.");
+  }
+  [ChromeEarlGrey loadURL:GURL("chrome://version")];
+  [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
+      performAction:grey_typeText(@"javascript:alert('Hello');")];
+
+  [[EarlGrey selectElementWithMatcher:grey_accessibilityID(@"Go")]
+      performAction:grey_tap()];
+
+  [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(@"Hello")]
+      assertWithMatcher:grey_nil()];
+}
+
 // Tests typing in the omnibox.
 - (void)testToolbarOmniboxTyping {
   SelectNewTabPagePanel(NewTabPage::kMostVisitedPanel);
 
   id<GREYMatcher> locationbarButton = grey_allOf(
       grey_accessibilityLabel(l10n_util::GetNSString(IDS_OMNIBOX_EMPTY_HINT)),
       grey_minimumVisiblePercent(0.2), nil);
   [[EarlGrey selectElementWithMatcher:locationbarButton]
       assertWithMatcher:grey_text(@"Search or type URL")];
 
@@ skipping 80 matching lines @@
 
     [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(clearText)]
         performAction:grey_tap()];
     [[EarlGrey selectElementWithMatcher:chrome_test_util::Omnibox()]
         assertWithMatcher:chrome_test_util::OmniboxText("")];
 
     SelectNewTabPagePanel(NewTabPage::kMostVisitedPanel);
   }
 }
 @end