Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation

Issue 2761153003: PlzNavigate & CSP. Use the SourceLocation in violation reports. (Closed)
Patch Set: Addressed comment @alexmos Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/content_security_policy_util.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
diff --git a/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
index e4c81a06e57face16fe0b586366101b385946990..60d77dd696a9c412c35da6a033291deb8bac1256 100644
--- a/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
+++ b/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation
@@ -6,15 +6,17 @@ crbug.com/551000 http/tests/inspector/network/x-frame-options-deny.html [ Failur
crbug.com/551000 virtual/mojo-loading/http/tests/inspector/network/x-frame-options-deny.html [ Failure ]
# https://crbug.com/690946 PlzNavigate: Missing line number in console messages when the 'frame-src' CSP is infringed.
-crbug.com/690946 http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html [ Failure ]
-crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-blocked.html [ Failure ]
-crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-child-frame-navigates-to-blocked-origin.html [ Failure ]
+# SourceLocation is not set when the navigation is initiated outside of a script.
crbug.com/690946 http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html [ Failure ]
-crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html [ Failure ]
-crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-src-blocked.html [ Failure ]
-crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-src-child-frame-navigates-to-blocked-origin.html [ Failure ]
crbug.com/690946 virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html [ Failure ]
# These tests are flaky.
Bug(none) http/tests/security/popup-allowed-by-sandbox-can-navigate.html [ Failure ]
Bug(none) virtual/mojo-loading/http/tests/security/popup-allowed-by-sandbox-can-navigate.html [ Failure ]
+
+# These tests are correct with PlzNavigate.
+# Without PlzNavigate, the line number of the console message is missing.
+Bug(none) http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html [ Failure ]
+Bug(none) http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.html [ Failure ]
+Bug(none) virtual/mojo-loading/http/tests/security/contentSecurityPolicy/1.1/child-src/frame-redirect-blocked.html [ Failure ]
+Bug(none) virtual/mojo-loading/http/tests/security/contentSecurityPolicy/frame-src-redirect-blocked.html [ Failure ]
« no previous file with comments | « content/renderer/content_security_policy_util.cc ('k') | third_party/WebKit/Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698