Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Unified Diff: content/common/content_security_policy/csp_context.h

Issue 2761153003: PlzNavigate & CSP. Use the SourceLocation in violation reports. (Closed)
Patch Set: Addressed comment @alexmos Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/content_security_policy/csp_context.h
diff --git a/content/common/content_security_policy/csp_context.h b/content/common/content_security_policy/csp_context.h
index fff6cf0140dec445eebbd0adc8663fe4a20d88ae..695dfe59e2528da0570c9b2f44e646f82fc078c8 100644
--- a/content/common/content_security_policy/csp_context.h
+++ b/content/common/content_security_policy/csp_context.h
@@ -10,6 +10,7 @@
#include "content/common/content_export.h"
#include "content/common/content_security_policy/content_security_policy.h"
#include "content/common/content_security_policy_header.h"
+#include "content/common/navigation_params.h"
#include "url/gurl.h"
#include "url/origin.h"
@@ -18,24 +19,29 @@ namespace content {
struct CSPViolationParams;
// A CSPContext represents the system on which the Content-Security-Policy are
-// enforced. One must define via its virtual methods how to report violations,
-// how to log messages on the console and what is the set of scheme that bypass
-// the CSP. Its main implementation is in
-// content/browser/frame_host/render_frame_host_impl.h
+// enforced. One must define via its virtual methods how to report violations
+// and what is the set of scheme that bypass the CSP. Its main implementation
+// is in content/browser/frame_host/render_frame_host_impl.h
class CONTENT_EXPORT CSPContext {
public:
CSPContext();
virtual ~CSPContext();
+ // Check if an |url| is allowed by the set of Content-Security-Policy. It will
+ // report any violation by:
+ // * displaying a console message.
+ // * triggering the "SecurityPolicyViolation" javascript event.
+ // * sending a JSON report to any uri defined with the "report-uri" directive.
+ // Returns true when the request can proceed, false otherwise.
bool IsAllowedByCsp(CSPDirective::Name directive_name,
const GURL& url,
- bool is_redirect = false);
+ bool is_redirect,
+ const SourceLocation& source_location);
void SetSelf(const url::Origin origin);
bool AllowSelf(const GURL& url);
bool ProtocolMatchesSelf(const GURL& url);
- virtual void LogToConsole(const std::string& message);
virtual void ReportContentSecurityPolicyViolation(
const CSPViolationParams& violation_params);
@@ -68,7 +74,8 @@ struct CONTENT_EXPORT CSPViolationParams {
const std::vector<std::string>& report_endpoints,
const std::string& header,
const blink::WebContentSecurityPolicyType& disposition,
- bool after_redirect);
+ bool after_redirect,
+ const SourceLocation& source_location);
CSPViolationParams(const CSPViolationParams& other);
~CSPViolationParams();
@@ -98,6 +105,9 @@ struct CONTENT_EXPORT CSPViolationParams {
// Whether or not the violation happens after a redirect.
bool after_redirect;
+
+ // The source code location that triggered the blocked navigation.
+ SourceLocation source_location;
};
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698