Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 2761143004: Ensure unoptimized code when collecting awaiter return stack trace. (Closed)

Created:
3 years, 9 months ago by Florian Schneider
Modified:
3 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure unoptimized code when collecting awaiter return stack trace. Fixes crashes when running reload stress tests with the async stack trace stress flag (python tools/test.py --hot-reload -t240 --builder-tag no_ipv6 language/await_exceptions_test) R=johnmccutchan@google.com Also: Use iterators to get function of a stack frame (refactoring only). Committed: https://github.com/dart-lang/sdk/commit/537eacb525575b422361fcfc5692e8f1b2820850

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M runtime/vm/debugger.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Florian Schneider
3 years, 9 months ago (2017-03-21 19:49:57 UTC) #2
Cutch
lgtm
3 years, 9 months ago (2017-03-21 19:51:47 UTC) #3
Florian Schneider
3 years, 9 months ago (2017-03-21 20:03:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
537eacb525575b422361fcfc5692e8f1b2820850 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698