Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2761033002: [Home] Position app menu based on location of anchor view (Closed)

Created:
3 years, 9 months ago by Theresa
Modified:
3 years, 9 months ago
Reviewers:
gone
CC:
chromium-reviews, agrieve+watch_chromium.org, mdjones
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Home] Position app menu based on location of anchor view If the anchor view for the app menu is at the top of the screen, the menu should have a negative vertical offset so that it covers the anchor view. If the anchor view is at the bottom of the screen, the menu should have a positive vertical offset so that it covers the anchor view. BUG=703317 Review-Url: https://codereview.chromium.org/2761033002 Cr-Commit-Position: refs/heads/master@{#458203} Committed: https://chromium.googlesource.com/chromium/src/+/f15ecdd181e4024a9c1ab850cac13acbe094da05

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use if-else block instead of inline conditional #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java View 1 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Theresa
dfalcantara@ - ptal
3 years, 9 months ago (2017-03-20 20:19:12 UTC) #2
gone
lgtm https://codereview.chromium.org/2761033002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java (right): https://codereview.chromium.org/2761033002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java#newcode287 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:287: // When the anchor view is at the ...
3 years, 9 months ago (2017-03-20 20:32:14 UTC) #3
Theresa
https://codereview.chromium.org/2761033002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java File chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java (right): https://codereview.chromium.org/2761033002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java#newcode287 chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java:287: // When the anchor view is at the top ...
3 years, 9 months ago (2017-03-20 21:11:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2761033002/20001
3 years, 9 months ago (2017-03-20 21:11:48 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 22:27:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f15ecdd181e4024a9c1ab850cac1...

Powered by Google App Engine
This is Rietveld 408576698