Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 27610002: Instantations of mixins and interfaces. Equality of type parameters. (Closed)

Created:
7 years, 2 months ago by rmacnak
Modified:
7 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org, ahe
Visibility:
Public.

Description

Generic instantiations of mixins and interfaces. Equality of type parameters. BUG=http://dartbug.com/14113 BUG=http://dartbug.com/14114 R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=28768

Patch Set 1 #

Total comments: 5

Patch Set 2 : check for resolved typeclass #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -31 lines) Patch
M runtime/lib/mirrors.cc View 1 8 chunks +121 lines, -12 lines 0 comments Download
M runtime/lib/mirrors_impl.dart View 8 chunks +34 lines, -7 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 2 chunks +1 line, -3 lines 0 comments Download
M tests/lib/mirrors/generic_mixin_test.dart View 4 chunks +7 lines, -9 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
rmacnak
Tried to refactor this a bit but it broke, so pushing it off and filed ...
7 years, 2 months ago (2013-10-16 23:15:00 UTC) #1
regis
LGTM https://codereview.chromium.org/27610002/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/27610002/diff/1/runtime/lib/mirrors.cc#newcode1006 runtime/lib/mirrors.cc:1006: const Class& cls = Class::Handle(type.type_class()); If someone passes ...
7 years, 2 months ago (2013-10-16 23:35:00 UTC) #2
rmacnak
https://codereview.chromium.org/27610002/diff/1/runtime/lib/mirrors.cc File runtime/lib/mirrors.cc (right): https://codereview.chromium.org/27610002/diff/1/runtime/lib/mirrors.cc#newcode1006 runtime/lib/mirrors.cc:1006: const Class& cls = Class::Handle(type.type_class()); On 2013/10/16 23:35:01, regis ...
7 years, 2 months ago (2013-10-17 00:15:26 UTC) #3
rmacnak
Committed patchset #2 manually as r28768 (presubmit successful).
7 years, 2 months ago (2013-10-17 00:16:43 UTC) #4
ahe
7 years, 2 months ago (2013-10-17 08:07:11 UTC) #5
Message was sent while issue was closed.
DBC

https://codereview.chromium.org/27610002/diff/6001/tests/lib/mirrors/generic_...
File tests/lib/mirrors/generic_mixin_test.dart (right):

https://codereview.chromium.org/27610002/diff/6001/tests/lib/mirrors/generic_...
tests/lib/mirrors/generic_mixin_test.dart:66:
typeArguments(reflectClass(GenericMultipleMixins).superclass.superclass.superclass.mixin,
[reflectClass(GenericMultipleMixins).typeVariables[0]]);
Many long lines in this file.

Powered by Google App Engine
This is Rietveld 408576698