Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: mojo/bindings/js/support.cc

Issue 276093002: Two fixes for mojo JS bindings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: alias Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/bindings/js/waiting_callback.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/bindings/js/support.cc
diff --git a/mojo/bindings/js/support.cc b/mojo/bindings/js/support.cc
index cb8cb99665d6dcfe9ae6274f40ed6054ffd7a2ad..ac6cb3400fa68353f5ca7297c20d31d7a1d969d8 100644
--- a/mojo/bindings/js/support.cc
+++ b/mojo/bindings/js/support.cc
@@ -25,30 +25,11 @@ namespace {
WaitingCallback* AsyncWait(const gin::Arguments& args, mojo::Handle handle,
MojoWaitFlags flags,
v8::Handle<v8::Function> callback) {
- gin::Handle<WaitingCallback> waiting_callback =
- WaitingCallback::Create(args.isolate(), callback);
-
- MojoAsyncWaiter* waiter = GetDefaultAsyncWaiter();
- MojoAsyncWaitID wait_id = waiter->AsyncWait(
- waiter,
- handle.value(),
- flags,
- MOJO_DEADLINE_INDEFINITE,
- &WaitingCallback::CallOnHandleReady,
- waiting_callback.get());
-
- waiting_callback->set_wait_id(wait_id);
-
- return waiting_callback.get();
+ return WaitingCallback::Create(args.isolate(), callback, handle, flags).get();
}
void CancelWait(WaitingCallback* waiting_callback) {
- if (!waiting_callback->wait_id())
- return;
-
- MojoAsyncWaiter* waiter = GetDefaultAsyncWaiter();
- waiter->CancelWait(waiter, waiting_callback->wait_id());
- waiting_callback->set_wait_id(0);
+ waiting_callback->Cancel();
}
gin::WrapperInfo g_wrapper_info = { gin::kEmbedderNativeGin };
« no previous file with comments | « no previous file | mojo/bindings/js/waiting_callback.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698