Eliminate multi-callback structure for LibraryLoader.

tests/compiler/dart2js/memory_compiler.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.test.memory_compiler;
 
 import 'dart:async';
 
 import 'package:compiler/compiler.dart' show DiagnosticHandler;
 import 'package:compiler/compiler_new.dart'
     show
         CompilationResult,
         CompilerDiagnostics,
         CompilerOutput,
         Diagnostic,
         PackagesDiscoveryProvider;
 import 'package:compiler/src/diagnostics/messages.dart' show Message;
+import 'package:compiler/src/elements/elements.dart' show LibraryElement;
 import 'package:compiler/src/enqueue.dart' show ResolutionEnqueuer;
 import 'package:compiler/src/null_compiler_output.dart' show NullCompilerOutput;
 import 'package:compiler/src/library_loader.dart' show LoadedLibraries;
 import 'package:compiler/src/options.dart' show CompilerOptions;
 
 import 'memory_source_file_helper.dart';
 
 export 'output_collector.dart';
 export 'package:compiler/compiler_new.dart' show CompilationResult;
 export 'diagnostic_helper.dart';
@@ skipping 131 matching lines @@
           packageConfig: packageConfig,
           packagesDiscoveryProvider: packagesDiscoveryProvider));
 
   if (cachedCompiler != null) {
     compiler.types = cachedCompiler.types.copy(compiler.resolution);
     Map copiedLibraries = {};
     cachedCompiler.libraryLoader.libraries.forEach((library) {
       if (library.isPlatformLibrary) {
         var libraryLoader = compiler.libraryLoader;
         libraryLoader.mapLibrary(library);
-        compiler.onLibraryCreated(library);
-        compiler.onLibraryScanned(library, null);
-        if (library.isPatched) {
-          var patchLibrary = library.patch;
-          compiler.onLibraryCreated(patchLibrary);
-          compiler.onLibraryScanned(patchLibrary, null);
-        }
         copiedLibraries[library.canonicalUri] = library;
       }
     });
-    // TODO(johnniwinther): Assert that no libraries are loaded lazily from
-    // this call.
-    compiler.onLibrariesLoaded(new MemoryLoadedLibraries(copiedLibraries));
+    compiler.processLoadedLibraries(new MemoryLoadedLibraries(copiedLibraries));
     ResolutionEnqueuer resolutionEnqueuer = compiler.startResolution();
 
     compiler.backend.constantCompilerTask
         .copyConstantValues(cachedCompiler.backend.constantCompilerTask);
 
     Iterable cachedTreeElements =
         cachedCompiler.enqueuer.resolution.processedEntities;
     cachedTreeElements.forEach((element) {
       if (element.library.isPlatformLibrary) {
         resolutionEnqueuer.registerProcessedElementInternal(element);
@@ skipping 17 matching lines @@
     // more than once.
     cachedCompiler.deferredLoadTask = null;
     cachedCompiler.mirrorUsageAnalyzerTask = null;
     cachedCompiler.dumpInfoTask = null;
   }
   return compiler;
 }
 
 class MemoryLoadedLibraries implements LoadedLibraries {
   final Map copiedLibraries;
+  final loader = null;

[Siggi Cherem (dart-lang), 2017/03/24 17:40:28]

delete?

 
   MemoryLoadedLibraries(this.copiedLibraries);
 
   @override
   bool containsLibrary(Uri uri) => copiedLibraries.containsKey(uri);
 
   @override
-  void forEachImportChain(f, {callback}) {}
+  void forEachImportChain(f, {callback}) {
+    throw new UnimplementedError();
+  }
 
   @override
-  void forEachLibrary(f) {}
+  void forEachLibrary(f) => copiedLibraries.values.forEach(f);
 
   @override
   getLibrary(Uri uri) => copiedLibraries[uri];
 
   @override
-  Uri get rootUri => null;
+  LibraryElement get rootLibrary => copiedLibraries.values.first;
 }
 
 DiagnosticHandler createDiagnosticHandler(DiagnosticHandler diagnosticHandler,
     SourceFileProvider provider, bool showDiagnostics) {
   var handler = diagnosticHandler;
   if (showDiagnostics) {
     if (diagnosticHandler == null) {
       handler = new FormattingDiagnosticHandler(provider);
     } else {
       var formattingHandler = new FormattingDiagnosticHandler(provider);
       handler = (Uri uri, int begin, int end, String message, Diagnostic kind) {
         diagnosticHandler(uri, begin, end, message, kind);
         formattingHandler(uri, begin, end, message, kind);
       };
     }
   } else if (diagnosticHandler == null) {
     handler = (Uri uri, int begin, int end, String message, Diagnostic kind) {};
   }
   return handler;
 }