Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Unified Diff: milo/appengine/common/acl.go

Issue 2760873003: Milo: Use luci-config for storing buildbot acls (Closed)
Patch Set: Fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/pubsub_test.go ('k') | milo/appengine/common/acl_test.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/common/acl.go
diff --git a/milo/appengine/common/acl.go b/milo/appengine/common/acl.go
index e01af88f5eaa0bfc0b7b64a824e78f7e883cab08..eb9fcef3e7e517945231eac95237e305df8519c6 100644
--- a/milo/appengine/common/acl.go
+++ b/milo/appengine/common/acl.go
@@ -5,10 +5,12 @@
package common
import (
+ "golang.org/x/net/context"
+
"github.com/luci/luci-go/luci_config/common/cfgtypes"
"github.com/luci/luci-go/luci_config/server/cfgclient/access"
"github.com/luci/luci-go/luci_config/server/cfgclient/backend"
- "golang.org/x/net/context"
+ "github.com/luci/luci-go/server/auth"
)
// Helper functions for ACL checking.
@@ -33,6 +35,9 @@ func IsAllowed(c context.Context, project string) (bool, error) {
// IsAllowedInternal is a shorthand for checking to see if the user is a reader
// of a magic project named "chrome".
func IsAllowedInternal(c context.Context) (bool, error) {
- // TODO(hinoka): Move this to luci-cfg.
- return IsAllowed(c, "chrome")
+ settings, err := GetSettings(c)
+ if err != nil {
+ return false, err
+ }
+ return auth.IsMember(c, settings.Buildbot.InternalReader)
}
« no previous file with comments | « milo/appengine/buildbot/pubsub_test.go ('k') | milo/appengine/common/acl_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698