Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1033)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: milo/appengine/frontend/config.go

Issue 2760873003: Milo: Use luci-config for storing buildbot acls (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« milo/appengine/common/config.go ('K') | « milo/appengine/common/config_test.go ('k') | milo/appengine/frontend/cron.yaml » ('j') | milo/common/config/settings.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/frontend/config.go
diff --git a/milo/appengine/frontend/config.go b/milo/appengine/frontend/config.go
index 2006a75081f4f0181b223854db590fc86f7e80f4..d8414c8f594408af8c2e163a6e8b7ebaf9d30b6d 100644
--- a/milo/appengine/frontend/config.go
+++ b/milo/appengine/frontend/config.go
@@ -29,9 +29,10 @@ func ConfigsHandler(c *router.Context) {
}
// UpdateHandler is an HTTP handler that handles configuration update requests.
-func UpdateHandler(ctx *router.Context) {
+// TODO(hinoka): Migrate to cfgclient and remove this.
+func UpdateConfigHandler(ctx *router.Context) {
hinoka 2017/03/20 20:35:49 Addressing leftover comments from the last CL
c, h := ctx.Context, ctx.Writer
- err := common.Update(c)
+ err := common.UpdateProjectConfigs(c)
if err != nil {
logging.WithError(err).Errorf(c, "Update Handler encountered error")
h.WriteHeader(500)
« milo/appengine/common/config.go ('K') | « milo/appengine/common/config_test.go ('k') | milo/appengine/frontend/cron.yaml » ('j') | milo/common/config/settings.proto » ('J')

Powered by Google App Engine
This is Rietveld 408576698