milo/common/config/settings.proto - Issue 2760873003: Milo: Use luci-config for storing buildbot acls

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: milo/common/config/settings.proto

Issue 2760873003: Milo: Use luci-config for storing buildbot acls (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright (c) 2016 The LUCI Authors. All rights reserved.

	2 // Use of this source code is governed under the Apache License, Version 2.0

	3 // that can be found in the LICENSE file.

	4

	5 syntax = "proto3";

	6

	7 package config;

	8

	9 // Settings represents the format for the global (service) config for Milo.

	10 message Settings{

	11 // buildbot_reader is the infra-auth group that is allowed to read internal

	12 // buildbot data.

	13 string buildbot_internal_reader = 1;
	nodir 2017/03/20 21:41:32 presumably we'll have more buildbot-specific setti presumably we'll have more buildbot-specific settings. please make a message Buildbot and put internal_reader there. hinoka 2017/03/20 22:19:26 This seems a little opportunistic, but sure. Done Show quoted text On 2017/03/20 21:41:32, nodir wrote: > presumably we'll have more buildbot-specific settings. > please make a message Buildbot and put internal_reader there. This seems a little opportunistic, but sure. Done.
	14 }

OLD	NEW