Add readback path for CopyTextureCHROMIUM

gpu/command_buffer/tests/gl_copy_texture_CHROMIUM_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef GL_GLEXT_PROTOTYPES
 #define GL_GLEXT_PROTOTYPES
 #endif
 
 #include <GLES2/gl2.h>
 #include <GLES2/gl2ext.h>
@@ skipping 491 matching lines @@
     width_ = 8;
     height_ = 8;
   }
 
   // If a driver isn't capable of supporting ES3 context, creating
   // ContextGroup will fail. Just skip the test.
   bool ShouldSkipTest() const {
     return (!gl_.decoder() || !gl_.decoder()->GetContextGroup());
   }
 
-  // RGB9_E5 isn't accepted by glCopyTexImage2D if underlying context is ES.
-  // TODO(qiankun.miao@intel.com): we should support RGB9_E5 in ES context.
-  // Maybe, we can add a readback path for RGB9_E5 format in ES context.
-  bool ShouldSkipRGB9_E5() const {
-    DCHECK(!ShouldSkipTest());
-    const gl::GLVersionInfo& gl_version_info =
-        gl_.decoder()->GetFeatureInfo()->gl_version_info();
-    return gl_version_info.is_es;
-  }
-
   // If EXT_color_buffer_float isn't available, float format isn't supported.
   bool ShouldSkipFloatFormat() const {
     DCHECK(!ShouldSkipTest());
     return !gl_.decoder()->GetFeatureInfo()->ext_color_buffer_float_available();
   }
 
   bool ShouldSkipBGRA() const {
     DCHECK(!ShouldSkipTest());
     return !gl_.decoder()
                 ->GetFeatureInfo()
                 ->feature_flags()
                 .ext_texture_format_bgra8888;
   }
 
   bool ShouldSkipSRGBEXT() const {
     DCHECK(!ShouldSkipTest());
     return !gl_.decoder()->GetFeatureInfo()->feature_flags().ext_srgb;
   }
-
-  // RGB5_A1 is not color-renderable on NVIDIA Mac, see crbug.com/676209.
-  bool ShouldSkipRGB5_A1() const {
-    DCHECK(!ShouldSkipTest());
-#if defined(OS_MACOSX)
-    return true;
-#else
-    return false;
-#endif
-  }
 };
 
 INSTANTIATE_TEST_CASE_P(CopyType,
                         GLCopyTextureCHROMIUMTest,
                         ::testing::ValuesIn(kCopyTypes));
 
 INSTANTIATE_TEST_CASE_P(CopyType,
                         GLCopyTextureCHROMIUMES3Test,
                         ::testing::ValuesIn(kCopyTypes));
 
@@ skipping 89 matching lines @@
       {GL_RGB5_A1, GL_RGBA, GL_UNSIGNED_BYTE},
       {GL_RGBA4, GL_RGBA, GL_UNSIGNED_BYTE},
       {GL_RGBA16F, GL_RGBA, GL_HALF_FLOAT},
       {GL_RGBA16F, GL_RGBA, GL_FLOAT},
       {GL_RGBA32F, GL_RGBA, GL_FLOAT},
       {GL_RGBA8UI, GL_RGBA_INTEGER, GL_UNSIGNED_BYTE},
   };
 
   for (auto src_format_type : src_format_types) {
     for (auto dest_format_type : dest_format_types) {
-      if (dest_format_type.internal_format == GL_RGB9_E5 && ShouldSkipRGB9_E5())
-        continue;
       if ((src_format_type.internal_format == GL_BGRA_EXT ||
            src_format_type.internal_format == GL_BGRA8_EXT ||
            dest_format_type.internal_format == GL_BGRA_EXT ||
            dest_format_type.internal_format == GL_BGRA8_EXT) &&
           ShouldSkipBGRA()) {
         continue;
       }
       if (gles2::GLES2Util::IsFloatFormat(dest_format_type.internal_format) &&
           ShouldSkipFloatFormat())
         continue;
       if ((dest_format_type.internal_format == GL_SRGB_EXT ||
            dest_format_type.internal_format == GL_SRGB_ALPHA_EXT) &&
           ShouldSkipSRGBEXT())
         continue;
-      if (dest_format_type.internal_format == GL_RGB5_A1 && ShouldSkipRGB5_A1())
-        continue;
 
       RunCopyTexture(GL_TEXTURE_2D, copy_type, src_format_type, 0,
                      dest_format_type, 0, true);
     }
   }
 }
 
 TEST_P(GLCopyTextureCHROMIUMTest, ImmutableTexture) {
   if (!GLTestHelper::HasExtension("GL_EXT_texture_storage")) {
     LOG(INFO) << "GL_EXT_texture_storage not supported. Skipping test...";
@@ skipping 949 matching lines @@
         }
       }
 
       glDeleteTextures(2, textures_);
       glDeleteFramebuffers(1, &framebuffer_id_);
     }
   }
 }
 
 }  // namespace gpu