Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp

Issue 2760793002: Use v8::Context::NewRemoteContext in RemoteWindowProxy. (Closed)
Patch Set: Clean up association logic Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
index c402611078422e49fe7c9245c90d9a4612537e11..049f2df7203fd461c12fcf92f45ffd3b7ea02098 100644
--- a/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/LocalWindowProxy.cpp
@@ -220,8 +220,9 @@ void LocalWindowProxy::setupWindowPrototypeChain() {
// The global object, aka window wrapper object.
v8::Local<v8::Object> windowWrapper =
globalProxy->GetPrototype().As<v8::Object>();
- windowWrapper = V8DOMWrapper::associateObjectWithWrapper(
- isolate(), window, wrapperTypeInfo, windowWrapper);
+ v8::Local<v8::Object> associatedWrapper =
+ associateWithWrapper(window, wrapperTypeInfo, windowWrapper);
+ DCHECK(associatedWrapper == windowWrapper);
// The prototype object of Window interface.
v8::Local<v8::Object> windowPrototype =

Powered by Google App Engine
This is Rietveld 408576698