Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/RemoteWindowProxy.h

Issue 2760793002: Use v8::Context::NewRemoteContext in RemoteWindowProxy. (Closed)
Patch Set: Clean up association logic Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 14 matching lines...) Expand all
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef RemoteWindowProxy_h 31 #ifndef RemoteWindowProxy_h
32 #define RemoteWindowProxy_h 32 #define RemoteWindowProxy_h
33 33
34 #include "bindings/core/v8/DOMWrapperWorld.h" 34 #include "bindings/core/v8/DOMWrapperWorld.h"
35 #include "bindings/core/v8/ScriptState.h"
36 #include "bindings/core/v8/WindowProxy.h" 35 #include "bindings/core/v8/WindowProxy.h"
37 #include "core/frame/RemoteFrame.h" 36 #include "core/frame/RemoteFrame.h"
38 #include "v8/include/v8.h" 37 #include "v8/include/v8.h"
39 #include "wtf/RefPtr.h" 38 #include "wtf/RefPtr.h"
40 39
41 namespace blink { 40 namespace blink {
42 41
43 // Subclass of WindowProxy that only handles RemoteFrame. 42 // Subclass of WindowProxy that only handles RemoteFrame.
44 // TODO(dcheng): This class temporarily contains code duplicated from 43 // TODO(dcheng): This class temporarily contains code duplicated from
45 // LocalWindowProxy. It will be removed once the global proxy is instantiated 44 // LocalWindowProxy. It will be removed once the global proxy is instantiated
46 // using v8::Context::NewRemoteContext(). 45 // using v8::Context::NewRemoteContext().
47 class RemoteWindowProxy final : public WindowProxy { 46 class RemoteWindowProxy final : public WindowProxy {
48 public: 47 public:
49 static RemoteWindowProxy* create(v8::Isolate* isolate, 48 static RemoteWindowProxy* create(v8::Isolate* isolate,
50 RemoteFrame& frame, 49 RemoteFrame& frame,
51
52 RefPtr<DOMWrapperWorld> world) { 50 RefPtr<DOMWrapperWorld> world) {
53 return new RemoteWindowProxy(isolate, frame, std::move(world)); 51 return new RemoteWindowProxy(isolate, frame, std::move(world));
54 } 52 }
55 53
56 private: 54 private:
57 RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>); 55 RemoteWindowProxy(v8::Isolate*, RemoteFrame&, RefPtr<DOMWrapperWorld>);
58 56
59 void initialize() override; 57 void initialize() override;
60 void disposeContext(GlobalDetachmentBehavior) override; 58 void disposeContext(GlobalDetachmentBehavior) override;
61 59
62 // Creates a new v8::Context with the window wrapper object as the global 60 // Creates a new v8::Context with the window wrapper object as the global
63 // object (aka the inner global). Note that the window wrapper and its 61 // object (aka the inner global). Note that the window wrapper and its
64 // prototype chain do not get fully initialized yet, e.g. the window 62 // prototype chain do not get fully initialized yet, e.g. the window
65 // wrapper is not yet associated with the native DOMWindow object. 63 // wrapper is not yet associated with the native DOMWindow object.
66 void createContext(); 64 void createContext();
67 65
68 // Associates the window wrapper and its prototype chain with the native 66 // Associates the window wrapper and its prototype chain with the native
69 // DOMWindow object. Also does some more Window-specific initialization. 67 // DOMWindow object. Also does some more Window-specific initialization.
70 void setupWindowPrototypeChain(); 68 void setupWindowPrototypeChain();
71
72 RefPtr<ScriptState> m_scriptState;
73 }; 69 };
74 70
75 } // namespace blink 71 } // namespace blink
76 72
77 #endif // RemoteWindowProxy_h 73 #endif // RemoteWindowProxy_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698