Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3441)

Unified Diff: chrome/browser/ui/webui/print_preview/print_preview_ui.cc

Issue 2760753002: [CUPS] Implement the local CUPS printer setup waiting UI. (Closed)
Patch Set: Address thestig@'s comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/print_preview/search/destination_search.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/print_preview/print_preview_ui.cc
diff --git a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
index b78c75dda004427eac79397f7c564a76aab0ce39..1bf4390768680b5cee55c4a0423298004e5f41fe 100644
--- a/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
+++ b/chrome/browser/ui/webui/print_preview/print_preview_ui.cc
@@ -235,11 +235,13 @@ content::WebUIDataSource* CreatePrintPreviewUISource() {
source->AddLocalizedString(
"resolveExtensionUSBErrorMessage",
IDS_PRINT_PREVIEW_RESOLVE_EXTENSION_USB_ERROR_MESSAGE);
- source->AddLocalizedString(
- "resolveCrosPrinterMessage",
- IDS_PRINT_PREVIEW_RESOLVE_CROS_DESTINATION_MESSAGE);
const base::string16 shortcut_text(base::UTF8ToUTF16(kBasicPrintShortcut));
Lei Zhang 2017/03/30 23:37:56 Move this inside #else?
xdai1 2017/03/30 23:47:21 Sorry! Missed this in your previous comment. Done.
-#if !defined(OS_CHROMEOS)
+#if defined(OS_CHROMEOS)
+ source->AddLocalizedString("configuringInProgressText",
+ IDS_PRINT_CONFIGURING_IN_PROGRESS_TEXT);
+ source->AddLocalizedString("configuringFailedText",
+ IDS_PRINT_CONFIGURING_FAILED_TEXT);
+#else
source->AddString(
"systemDialogOption",
l10n_util::GetStringFUTF16(
« no previous file with comments | « chrome/browser/resources/print_preview/search/destination_search.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698