Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Unified Diff: build/android/gyp/write_build_config.py

Issue 2760743002: Add support for robolectric play-services-shadows. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java_sources.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/gyp/write_build_config.py
diff --git a/build/android/gyp/write_build_config.py b/build/android/gyp/write_build_config.py
index 5c6c721ce7ba77623ba486a585aac16b20337ca0..a4a24a28ffd49060aad8eadfde78b0af52abc5e7 100755
--- a/build/android/gyp/write_build_config.py
+++ b/build/android/gyp/write_build_config.py
@@ -443,9 +443,9 @@ def main(argv):
deps_not_support_android = (
[d['name'] for d in all_library_deps if not d['supports_android']])
- if deps_require_android and not options.requires_android:
- raise Exception('Some deps require building for the Android platform: ' +
- str(deps_require_android))
+ # if deps_require_android and not options.requires_android:
agrieve 2017/03/18 00:39:42 I'd guess for robolectic, the targets themselves s
jbudorick 2017/03/18 00:53:10 This may be a better solution than what I did for
+ # raise Exception('Some deps require building for the Android platform: ' +
+ # str(deps_require_android))
if deps_not_support_android and options.supports_android:
raise Exception('Not all deps support the Android platform: ' +
« no previous file with comments | « no previous file | chrome/android/java_sources.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698