Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: chrome/browser/autocomplete/search_provider.h

Issue 276073002: [AiS] Provide Answers queries with a session token. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/autocomplete/search_provider.h
diff --git a/chrome/browser/autocomplete/search_provider.h b/chrome/browser/autocomplete/search_provider.h
index 90a3f96f2dc42d8ff0d7afdb2addf6a7ec2f1ae9..ea71862ad301fba78b0dfbdf14ca8d8418b00e89 100644
--- a/chrome/browser/autocomplete/search_provider.h
+++ b/chrome/browser/autocomplete/search_provider.h
@@ -64,6 +64,8 @@ class SearchProvider : public BaseSearchProvider {
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineDomainClassify);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, NavigationInlineSchemeSubstring);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, RemoveStaleResultsTest);
+ FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SessionToken);
Peter Kasting 2014/05/09 21:35:07 Nit: List tests here in the same order as the test
groby-ooo-7-16 2014/05/09 21:50:25 Ah. I assumed alphabetical order.
groby-ooo-7-16 2014/05/09 22:18:09 Done.
+ FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SuggestQueryUsesToken);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, SuggestRelevanceExperiment);
FRIEND_TEST_ALL_PREFIXES(SearchProviderTest, TestDeleteMatch);
FRIEND_TEST_ALL_PREFIXES(AutocompleteProviderTest, GetDestinationURL);
@@ -270,6 +272,9 @@ class SearchProvider : public BaseSearchProvider {
// Updates the value of |done_| from the internal state.
void UpdateDone();
+ // Obtain a session token, regenerating if necessary.
Peter Kasting 2014/05/09 21:35:07 Nit: Obtains
groby-ooo-7-16 2014/05/09 22:18:09 Done.
+ std::string GetSessionToken();
+
// The amount of time to wait before sending a new suggest request after the
// previous one. Non-const because some unittests modify this value.
static int kMinimumTimeBetweenSuggestQueriesMs;
@@ -304,6 +309,10 @@ class SearchProvider : public BaseSearchProvider {
GURL current_page_url_;
+ // Session token management.
+ std::string current_token_;
+ base::Time token_expiration_time_;
+
DISALLOW_COPY_AND_ASSIGN(SearchProvider);
};
« no previous file with comments | « no previous file | chrome/browser/autocomplete/search_provider.cc » ('j') | chrome/browser/autocomplete/search_provider.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698