[AiS] Provide Answers queries with a session token.

chrome/browser/autocomplete/search_provider_unittest.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/autocomplete/search_provider.h"
 
 #include <string>
 
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
@@ skipping 3054 matching lines @@
   // Verbatim match duplicates are added such that each one has a higher
   // relevance than the previous one.
   EXPECT_EQ(2U, verbatim.duplicate_matches.size());
 
   // Other match duplicates are added in descending relevance order.
   EXPECT_EQ(1U, match_alpha.duplicate_matches.size());
   EXPECT_EQ(1U, match_avid.duplicate_matches.size());
 
   EXPECT_EQ(0U, match_apricot.duplicate_matches.size());
 }
+
+#if defined(OS_ANDROID)
+TEST_F(SearchProviderTest, SuggestQueryUsesToken) {
+  CommandLine::ForCurrentProcess()->AppendSwitch(
+      switches::kEnableAnswersInSuggest);
+
+  TemplateURLService* turl_model =
+      TemplateURLServiceFactory::GetForProfile(&profile_);
+
+  TemplateURLData data;
+  data.short_name = ASCIIToUTF16("default");
+  data.SetKeyword(data.short_name);
+  data.SetURL("http://example/{searchTerms}{google:sessionToken}");
+  data.suggestions_url =
+      "http://suggest/?q={searchTerms}&{google:sessionToken}";
+  default_t_url_ = new TemplateURL(&profile_, data);
+  turl_model->Add(default_t_url_);
+  turl_model->SetUserSelectedDefaultSearchProvider(default_t_url_);
+
+  base::string16 term = term1_.substr(0, term1_.length() - 1);
+  QueryForInput(term, false, false);
+
+  // Make sure the default providers suggest service was queried.

[Peter Kasting, 2014/05/09 21:35:07]

Nit: provider's

[groby-ooo-7-16, 2014/05/09 22:18:09]

Done.

+  net::TestURLFetcher* fetcher = test_factory_.GetFetcherByID(
+      SearchProvider::kDefaultProviderURLFetcherID);
+  ASSERT_TRUE(fetcher);
+
+  // And the URL matches what we expected.
+  TemplateURLRef::SearchTermsArgs search_terms_args(term);
+  search_terms_args.session_token = provider_->current_token_;

[Peter Kasting, 2014/05/09 21:35:07]

Can this use GetSessionToken()?  If so, perhaps these tests can be un-friended
just by making that function public.

[groby-ooo-7-16, 2014/05/09 21:50:25]

Second test needs access to expiration time, so we can't do that. This one
could, but it relies on there not being 60 seconds between QueryForInput and the
check. Which means both this and the next test could flake around DST :(

In light of that, I think you're right, TimeTicks is the better choice, even
though it means clock suspension extends the lifetime of the token.

+  GURL expected_url(default_t_url_->suggestions_url_ref().ReplaceSearchTerms(
+      search_terms_args));
+  EXPECT_EQ(fetcher->GetOriginalURL().spec(), expected_url.spec());
+
+  // complete running the fetcher to clean up.

[Peter Kasting, 2014/05/09 21:35:07]

Nit: Capitalize

[groby-ooo-7-16, 2014/05/09 22:18:09]

Done.

+  fetcher->set_response_code(200);
+  fetcher->delegate()->OnURLFetchComplete(fetcher);
+  RunTillProviderDone();
+}
+#endif
+
+TEST_F(SearchProviderTest, SessionToken) {
+  const base::TimeDelta small_delta = base::TimeDelta::FromMilliseconds(1);

[Peter Kasting, 2014/05/09 21:35:07]

Nit: Declare this just above first use

[groby-ooo-7-16, 2014/05/09 22:18:09]

Done.

+  // Subsequent calls always get the same token.
+  std::string token = provider_->GetSessionToken();
+  std::string token2 = provider_->GetSessionToken();
+  EXPECT_EQ(token, token2);
+  EXPECT_FALSE(token.empty());
+
+  // Calls do not regenerate a token.
+  provider_->current_token_ = "PRE-EXISTING TOKEN";
+  token = provider_->GetSessionToken();
+  EXPECT_EQ(token, "PRE-EXISTING TOKEN");
+
+  // ... unless the token has expired.
+  provider_->current_token_ = "";

[Peter Kasting, 2014/05/09 21:35:07]

Nit: .clear()

[groby-ooo-7-16, 2014/05/09 22:18:09]

Done.

+  provider_->token_expiration_time_ = base::Time::Now() - small_delta;
+  token = provider_->GetSessionToken();
+  EXPECT_FALSE(token.empty());
+  EXPECT_EQ(token, provider_->current_token_);
+
+  // The expiration time is always updated.
+  provider_->GetSessionToken();
+  base::Time expiration_time_1 = provider_->token_expiration_time_;
+  base::PlatformThread::Sleep(small_delta);
+  provider_->GetSessionToken();
+  base::Time expiration_time_2 = provider_->token_expiration_time_;
+  EXPECT_GT(expiration_time_2, expiration_time_1);
+  EXPECT_GE(expiration_time_2, expiration_time_1 + small_delta);
+}