Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp

Issue 2760723002: Check X509Certificate::CreateFromHandle result. (Closed)
Patch Set: rebase on updated 2755203002 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/ssl/client_cert_store_nss.cc ('K') | « net/ssl/client_cert_store_win.cc ('k') | net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp
diff --git a/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp b/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp
index a2466559da444ee0aaba932987b908c8db742a82..505a46ffae87bc7ff1fbdc05e6f224c9b844aeda 100644
--- a/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp
+++ b/net/third_party/mozilla_security_manager/nsPKCS12Blob.cpp
@@ -225,8 +225,10 @@ nsPKCS12Blob_ImportHelper(const char* pkcs12_data,
if (imported_certs) {
// Empty list of intermediates.
net::X509Certificate::OSCertHandles intermediates;
- imported_certs->push_back(
- net::X509Certificate::CreateFromHandle(cert, intermediates));
+ scoped_refptr<net::X509Certificate> x509_cert =
+ net::X509Certificate::CreateFromHandle(cert, intermediates);
+ if (x509_cert)
+ imported_certs->push_back(x509_cert);
eroman 2017/03/22 22:17:52 move?
mattm 2017/03/23 22:59:03 Done.
}
// Once we have determined that the imported certificate has an
« net/ssl/client_cert_store_nss.cc ('K') | « net/ssl/client_cert_store_win.cc ('k') | net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698