Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/cert/x509_certificate.cc

Issue 2760723002: Check X509Certificate::CreateFromHandle result. (Closed)
Patch Set: rebase on updated 2755203002 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/cert/cert_verify_proc_mac.cc ('K') | « net/cert/nss_cert_database.cc ('k') | net/ssl/client_cert_store_mac.cc » ('j') | net/ssl/client_cert_store_nss.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/x509_certificate.cc
diff --git a/net/cert/x509_certificate.cc b/net/cert/x509_certificate.cc
index 377cb7e5215184f5cecb02f7be3b2d74f8e5c2c3..03d7a5dbc11f59fbfb16b9fab78c31c4a96ebf67 100644
--- a/net/cert/x509_certificate.cc
+++ b/net/cert/x509_certificate.cc
@@ -445,7 +445,10 @@ CertificateList X509Certificate::CreateCertificateListFromBytes(
for (OSCertHandles::iterator it = certificates.begin();
it != certificates.end(); ++it) {
- results.push_back(CreateFromHandle(*it, OSCertHandles()));
+ scoped_refptr<X509Certificate> cert =
+ CreateFromHandle(*it, OSCertHandles());
+ if (cert)
+ results.push_back(cert);
eroman 2017/03/22 22:17:52 std::move ?
mattm 2017/03/23 22:59:03 Done.
FreeOSCertHandle(*it);
}
« net/cert/cert_verify_proc_mac.cc ('K') | « net/cert/nss_cert_database.cc ('k') | net/ssl/client_cert_store_mac.cc » ('j') | net/ssl/client_cert_store_nss.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698