net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc - Issue 2760723002: Check X509Certificate::CreateFromHandle result.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc

Issue 2760723002: Check X509Certificate::CreateFromHandle result. (Closed)

Patch Set: 2nd round of updates Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc

diff --git a/net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc b/net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc

index 99cffc25914103387c9eed653601d68aaf81fa44..ba449fd326c73b0f0e54c604720cf453bbd2db0f 100644

--- a/net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc

+++ b/net/tools/cert_verify_tool/verify_using_cert_verify_proc.cc

@@ -62,6 +62,8 @@ std::string SubjectFromOSCertHandle(

scoped_refptr<net::X509Certificate> cert =

net::X509Certificate::CreateFromHandle(

cert_handle, net::X509Certificate::OSCertHandles());

+ if (!cert)

+ return std::string();

return SubjectFromX509Certificate(cert.get());

}