Check X509Certificate::CreateFromHandle result.

net/cert/x509_certificate.h

Index: net/cert/x509_certificate.h
diff --git a/net/cert/x509_certificate.h b/net/cert/x509_certificate.h
index 59f1b772fe7b7340c511c08a15ebaaf66cbad13f..7840292a9ecd158234a842b861649349ae0d569e 100644
--- a/net/cert/x509_certificate.h
+++ b/net/cert/x509_certificate.h
@@ -127,7 +127,11 @@ class NET_EXPORT X509Certificate
   };
 
   // Create an X509Certificate from a handle to the certificate object in the
-  // underlying crypto library.
+  // underlying crypto library. Returns NULL on failure to parse or extract

[eroman, 2017/03/23 23:41:31]

nit: NULL --> nullptr ?

[mattm, 2017/03/24 21:49:35]

All the other comments say NULL, so I'm not sure if it's better to be consistent
or not?

+  // data from the the certificate. Note that this does not guarantee the
+  // certificate is fully parsed and validated, only that the members of this
+  // class, such as subject, issuer, expiry times, and serial number, could be
+  // successfully initialized from the certificate.
   static scoped_refptr<X509Certificate> CreateFromHandle(
       OSCertHandle cert_handle,
       const OSCertHandles& intermediates);