chrome/browser/views/options/content_page_view.cc - Issue 276072: The login dialog was being opened with the main browser window as a parent in...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/options/content_page_view.cc

Issue 276072: The login dialog was being opened with the main browser window as a parent in... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/views/bookmark_manager_view.cc ('K') | « chrome/browser/views/bookmark_manager_view.cc ('k') | chrome/test/live_sync/profile_sync_service_test_harness.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/views/options/content_page_view.cc

===================================================================

--- chrome/browser/views/options/content_page_view.cc (revision 29327)

+++ chrome/browser/views/options/content_page_view.cc (working copy)

@@ -142,7 +142,7 @@

IDS_CONFIRM_STOP_SYNCING_DIALOG_HEIGHT_LINES)));

return;

} else {

- sync_service_->EnableForUser();

+ sync_service_->EnableForUser(GetWindow()->GetNativeWindow());

ProfileSyncService::SyncEvent(ProfileSyncService::START_FROM_OPTIONS);

}

#endif

@@ -160,7 +160,7 @@

#ifdef CHROME_PERSONALIZATION

DCHECK_EQ(source, sync_action_link_);

DCHECK(sync_service_);

- sync_service_->ShowLoginDialog();

+ sync_service_->ShowLoginDialog(GetWindow()->GetNativeWindow());

#endif

}