Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 276071: Don't overwrite email with lowercase value from GetUserInfo().... (Closed)

Created:
11 years, 2 months ago by RandyPosynick
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, leon.carl_gmail.com
Visibility:
Public.

Description

Don't overwrite email with lowercase value from GetUserInfo(). BUG=20848 TEST=See repro steps in bug.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -12 lines) Patch
M chrome/browser/sync/engine/auth_watcher.cc View 3 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
RandyPosynick
Talked with idana@chromium.org about the desired functionality for this and it was decided that the ...
11 years, 2 months ago (2009-10-16 21:44:54 UTC) #1
brg
LGTM
11 years, 2 months ago (2009-10-16 22:31:37 UTC) #2
tim (not reviewing)
On 2009/10/16 22:31:37, brg wrote: > LGTM Did someone land this?
11 years, 1 month ago (2009-10-30 23:21:44 UTC) #3
ncarter (slow)
On 2009/10/30 23:21:44, timsteele wrote: > On 2009/10/16 22:31:37, brg wrote: > > LGTM > ...
11 years, 1 month ago (2009-10-31 00:19:54 UTC) #4
idana
11 years, 1 month ago (2009-11-13 00:57:02 UTC) #5
I just landed this patch in r31865

Powered by Google App Engine
This is Rietveld 408576698