Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2760503003: [dart:io][windows] Stdout.supportsAnsiEscapes is false when not connected to a terminal (Closed)

Created:
3 years, 9 months ago by zra
Modified:
3 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[dart:io][windows] Stdout.supportsAnsiEscapes is false when not connected to a terminal Committed: https://github.com/dart-lang/sdk/commit/8fdab25117dcba8730f2a6c233fc434540f6777f

Patch Set 1 #

Patch Set 2 : More fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M runtime/bin/stdio_win.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
TBR
3 years, 9 months ago (2017-03-17 20:07:24 UTC) #2
zra
Committed patchset #2 (id:20001) manually as 8fdab25117dcba8730f2a6c233fc434540f6777f (presubmit successful).
3 years, 9 months ago (2017-03-17 20:07:48 UTC) #4
rmacnak
3 years, 9 months ago (2017-03-17 20:40:36 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698