Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2760493002: [UI] Remove LocationBar Page-Action related methods (Closed)

Created:
3 years, 9 months ago by Devlin
Modified:
3 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, mac-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[UI] Remove LocationBar Page-Action related methods Remove all page-action related methods from the LocationBar classes. These are no longer necessary since the extension action redesign launched (close to a year ago). BUG=590320 Review-Url: https://codereview.chromium.org/2760493002 Cr-Commit-Position: refs/heads/master@{#458110} Committed: https://chromium.googlesource.com/chromium/src/+/832a2a38ffa52552925358591ce672e296a80548

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove stale includes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -178 lines) Patch
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 3 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 4 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 6 chunks +1 line, -41 lines 0 comments Download
M chrome/browser/ui/location_bar/location_bar.h View 5 chunks +0 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 4 chunks +0 lines, -37 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download

Messages

Total messages: 28 (17 generated)
Devlin
Heya folks, mind taking a look? avi@ - cocoa pkasting@ - ui/views, ui/location_bar lazyboy@ - ...
3 years, 9 months ago (2017-03-17 15:56:32 UTC) #7
Avi (use Gerrit)
lgtm https://codereview.chromium.org/2760493002/diff/1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm File chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm (right): https://codereview.chromium.org/2760493002/diff/1/chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm#newcode29 chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm:29: #import "chrome/browser/ui/cocoa/info_bubble_view.h" On 2017/03/17 15:56:31, Devlin wrote: > ...
3 years, 9 months ago (2017-03-17 16:35:38 UTC) #8
lazyboy
lgtm
3 years, 9 months ago (2017-03-17 17:25:18 UTC) #9
Peter Kasting
LGTM
3 years, 9 months ago (2017-03-18 01:04:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760493002/1
3 years, 9 months ago (2017-03-18 01:06:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/388738)
3 years, 9 months ago (2017-03-18 01:15:21 UTC) #14
Devlin
+sky@ for chrome/test/base/test_browser_window.*; mind taking a look?
3 years, 9 months ago (2017-03-18 01:24:28 UTC) #16
sky
LGTM - if there are any stale includes please remove them.
3 years, 9 months ago (2017-03-20 15:46:16 UTC) #17
Devlin
On 2017/03/20 15:46:16, sky wrote: > if there are any stale includes please remove them. ...
3 years, 9 months ago (2017-03-20 17:23:01 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760493002/20001
3 years, 9 months ago (2017-03-20 17:23:33 UTC) #25
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 17:30:14 UTC) #28
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/832a2a38ffa52552925358591ce6...

Powered by Google App Engine
This is Rietveld 408576698