Fix handling of external protocols with PlzNavigate.

content/common/navigation_params.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/navigation_params.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "content/public/common/appcache_info.h"
 #include "content/public/common/browser_side_navigation_policy.h"
 #include "content/public/common/url_constants.h"
 #include "url/gurl.h"
 #include "url/url_constants.h"
+#include "url/url_util.h"
 
 namespace content {
 
 // PlzNavigate
 bool ShouldMakeNetworkRequestForURL(const GURL& url) {
   CHECK(IsBrowserSideNavigationEnabled());
 
-  // Javascript URLs, about:blank, srcdoc should not send a request
-  // to the network stack.
-  return !url.IsAboutBlank() && !url.SchemeIs(url::kJavaScriptScheme) &&
-         !url.is_empty() && !url.SchemeIs(url::kContentIDScheme) &&
-         url != content::kAboutSrcDocURL;
+  // Javascript URLs, srcdoc, schemes that don't load data should not send a
+  // request to the network stack.
+  bool rv =
+      !url.SchemeIs(url::kJavaScriptScheme) &&
+      !url.is_empty() && !url.SchemeIs(url::kContentIDScheme) &&
+      url != content::kAboutSrcDocURL;
+  if (rv) {
+    for (const auto& scheme : url::GetEmptyDocumentSchemes()) {
+      if (url.SchemeIs(scheme)) {
+        rv = false;
+        break;

[dcheng, 2017/03/23 21:07:15]

Nit: maybe slightly shorter to just return false directly?

[jam, 2017/03/23 21:43:21]

rewrote this to make it simpler

+      }
+    }
+  }
+  return rv;
 }
 
 SourceLocation::SourceLocation() : line_number(0), column_number(0) {}
 
 SourceLocation::SourceLocation(const std::string& url,
                                unsigned int line_number,
                                unsigned int column_number)
     : url(url), line_number(line_number), column_number(column_number) {}
 
 SourceLocation::~SourceLocation() {}
@@ skipping 175 matching lines @@
     const RequestNavigationParams& request_params)
     : common_params(common_params),
       start_params(start_params),
       request_params(request_params) {
 }
 
 NavigationParams::~NavigationParams() {
 }
 
 }  // namespace content