Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2760373003: [Remoting Android] Fix crash caused by fetchAuthToken() (Closed)

Created:
3 years, 9 months ago by Yuwei
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

[Remoting Android] Fix crash caused by fetchAuthToken() Previously auth token was only fetched after the account switcher set the account. A recent refactoring makes the app attempt to fetch the auth token even before the account is set, so the fetchAuthToken() function just throws an exception and crashes the app. Since we are pretty sure that the Java code will soon feed the logger with the auth code once the account is set, it's safe to fix this by loosening the check to just a warning log. Alternatively we can remove the immediate RequestAuthTokenForLogger() call from ChromotingClientRuntime and make the logger request the auth token before it tries to send out the logs. It depends on how the iOS client wants to provide the auth token. BUG=703381 Review-Url: https://codereview.chromium.org/2761983002 Cr-Commit-Position: refs/heads/master@{#458515} (cherry picked from commit ced631a3b4de3fd68d98ecc1620d76b47a5ea9b2)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760373003/1
3 years, 9 months ago (2017-03-21 21:03:51 UTC) #2
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 21:03:55 UTC) #4
No L-G-T-M from a valid reviewer yet.
CQ run can only be started once the patch has received an L-G-T-M from a full
committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a
full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

Powered by Google App Engine
This is Rietveld 408576698