Chromium Code Reviews
Description[Remoting Android] Fix crash caused by fetchAuthToken()
Previously auth token was only fetched after the account switcher set the
account. A recent refactoring makes the app attempt to fetch the auth token
even before the account is set, so the fetchAuthToken() function just throws
an exception and crashes the app.
Since we are pretty sure that the Java code will soon feed the logger with the
auth code once the account is set, it's safe to fix this by loosening the check
to just a warning log.
Alternatively we can remove the immediate RequestAuthTokenForLogger() call from
ChromotingClientRuntime and make the logger request the auth token before it
tries to send out the logs. It depends on how the iOS client wants to provide
the auth token.
BUG=703381
Review-Url: https://codereview.chromium.org/2761983002
Cr-Commit-Position: refs/heads/master@{#458515}
(cherry picked from commit ced631a3b4de3fd68d98ecc1620d76b47a5ea9b2)
Patch Set 1 #
Messages
Total messages: 5 (3 generated)
|
|||||||||||||||||||