Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 27603003: Add back module paths from old python_26 configuration. (Closed)

Created:
7 years, 2 months ago by Michael Moss
Modified:
7 years, 2 months ago
Reviewers:
M-A Ruel
CC:
tim (not reviewing), chromium-reviews
Visibility:
Public.

Description

Add back module paths from old python_26 configuration. R=maruel@chromium.org BUG=304949 Committed: 229213

Patch Set 1 #

Patch Set 2 : fix upload #

Patch Set 3 : modify PYTHONPATH instead of PATH #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M setup_env.bat View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Michael Moss
7 years, 2 months ago (2013-10-17 19:06:54 UTC) #1
Michael Moss
7 years, 2 months ago (2013-10-17 19:06:55 UTC) #2
Michael Moss
7 years, 2 months ago (2013-10-17 19:06:56 UTC) #3
Michael Moss
7 years, 2 months ago (2013-10-17 19:06:56 UTC) #4
Michael Moss
This fixes the import failure on bots that aren't using python 2.7.5 yet, e.g.: http://build.chromium.org/p/chromium/builders/Win/builds/17487/steps/compile/logs/stdio
7 years, 2 months ago (2013-10-17 19:10:22 UTC) #5
M-A Ruel
I'd prefer to have whatever library needed in src\third_party\python_26\Lib\site-packages\ in be extracted in a proper ...
7 years, 2 months ago (2013-10-17 19:18:53 UTC) #6
Michael Moss
On 2013/10/17 19:18:53, M-A Ruel wrote: > I'd prefer to have whatever library needed in ...
7 years, 2 months ago (2013-10-17 19:26:21 UTC) #7
M-A Ruel
On 2013/10/17 19:26:21, Michael Moss wrote: > On 2013/10/17 19:18:53, M-A Ruel wrote: > > ...
7 years, 2 months ago (2013-10-17 19:31:40 UTC) #8
Michael Moss
On 2013/10/17 19:31:40, M-A Ruel wrote: > On 2013/10/17 19:26:21, Michael Moss wrote: > > ...
7 years, 2 months ago (2013-10-17 19:35:31 UTC) #9
M-A Ruel
Yes, at least if it works.
7 years, 2 months ago (2013-10-17 19:41:19 UTC) #10
Michael Moss
On 2013/10/17 19:41:19, M-A Ruel wrote: > Yes, at least if it works. Done.
7 years, 2 months ago (2013-10-17 19:56:20 UTC) #11
M-A Ruel
lgtm
7 years, 2 months ago (2013-10-17 20:01:27 UTC) #12
Michael Moss
7 years, 2 months ago (2013-10-17 20:27:56 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 manually as r229213 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698