Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2050)

Unified Diff: tests/standalone/io/socket_finalizer_test.dart

Issue 2760293002: [dart:io] Adds a finalizer to _NativeSocket to avoid socket leaks (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/standalone/io/socket_bind_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/io/socket_finalizer_test.dart
diff --git a/tests/standalone/io/socket_finalizer_test.dart b/tests/standalone/io/socket_finalizer_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..ea7fb31700e18adfa81f5e1647e1b26b0d020e90
--- /dev/null
+++ b/tests/standalone/io/socket_finalizer_test.dart
@@ -0,0 +1,39 @@
+// Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+//
+// This test checks that sockets belonging to an isolate are properly cleaned up
+// when the isolate shuts down abnormally. If the socket is not properly cleaned
+// up, the test will time out.
+
+import 'dart:async';
+import 'dart:io';
+import 'dart:isolate';
+
+import "package:async_helper/async_helper.dart";
+import "package:expect/expect.dart";
+
+ConnectorIsolate(int port) async {
+ Socket socket = await Socket.connect("127.0.0.1", port);
+ socket.listen((_) {});
+}
+
+main() async {
+ asyncStart();
+ ServerSocket server = await ServerSocket.bind("127.0.0.1", 0);
+ Isolate isolate = await Isolate.spawn(ConnectorIsolate, server.port);
+ Completer<Null> completer = new Completer<Null>();
+ server.listen((Socket socket) {
+ socket.listen((_) {}, onDone: () {
+ print("Socket closed normally");
+ completer.complete(null);
+ socket.close();
+ }, onError: (e) {
+ Expect.fail("Socket error $e");
+ });
+ isolate.kill();
+ });
+ await completer.future;
+ await server.close();
+ asyncEnd();
+}
« no previous file with comments | « tests/standalone/io/socket_bind_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698