tests/standalone/io/socket_bind_test.dart - Issue 2760293002: [dart:io] Adds a finalizer to _NativeSocket to avoid socket leaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/standalone/io/socket_bind_test.dart

Issue 2760293002: [dart:io] Adds a finalizer to _NativeSocket to avoid socket leaks (Closed)

Patch Set: Add comments. Drain Windows IO completion port in Debug Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/standalone/io/socket_bind_test.dart

diff --git a/tests/standalone/io/socket_bind_test.dart b/tests/standalone/io/socket_bind_test.dart

index 08963eb36bcc0f949c9d31e1fb57d1ac7377e1fb..001e2b1e670e08b171837752349762fc048c61a4 100644

--- a/tests/standalone/io/socket_bind_test.dart

+++ b/tests/standalone/io/socket_bind_test.dart

@@ -110,6 +110,7 @@ testListenCloseListenClose(String host) async {

await client.close();

await client.drain();

+ await socket2.close();

Cutch 2017/03/27 17:17:50 maybe a comment why you're closing this socket.

zra 2017/03/28 14:40:19 Done.

asyncEnd();

}