[dart:io] Adds a finalizer to _NativeSocket to avoid socket leaks

runtime/bin/process.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #if !defined(DART_IO_DISABLED)
 
 #include "bin/process.h"
 
 #include "bin/dartutils.h"
 #include "bin/io_buffer.h"
@@ skipping 54 matching lines @@
       if (Dart_IsError(result)) {
         Dart_PropagateError(result);
       }
       return NULL;
     }
     string_args[i] = const_cast<char*>(DartUtils::GetStringValue(arg));
   }
   return string_args;
 }
 
+
+void Process::ClearAllSignalHandlers() {
+  for (intptr_t i = 1; i <= kLastSignal; i++) {
+    ClearSignalHandler(i);
+  }
+}
+
+
 void FUNCTION_NAME(Process_Start)(Dart_NativeArguments args) {
   Dart_Handle process = Dart_GetNativeArgument(args, 0);
   intptr_t process_stdin;
   intptr_t process_stdout;
   intptr_t process_stderr;
   intptr_t exit_event;
   Dart_Handle result;
   Dart_Handle status_handle = Dart_GetNativeArgument(args, 10);
   Dart_Handle path_handle = Dart_GetNativeArgument(args, 1);
   // The Dart code verifies that the path implements the String
@@ skipping 61 matching lines @@
   Dart_Handle exit_handle = Dart_GetNativeArgument(args, 9);
   intptr_t pid = -1;
   char* os_error_message = NULL;  // Scope allocated by Process::Start.
 
   int error_code = Process::Start(
       path, string_args, args_length, working_directory, string_environment,
       environment_length, static_cast<ProcessStartMode>(mode), &process_stdout,
       &process_stdin, &process_stderr, &pid, &exit_event, &os_error_message);
   if (error_code == 0) {
     if (mode != kDetached) {
-      Socket::SetSocketIdNativeField(stdin_handle, process_stdin);
-      Socket::SetSocketIdNativeField(stdout_handle, process_stdout);
-      Socket::SetSocketIdNativeField(stderr_handle, process_stderr);
+      Socket::SetSocketIdNativeField(stdin_handle, process_stdin, false);
+      Socket::SetSocketIdNativeField(stdout_handle, process_stdout, false);
+      Socket::SetSocketIdNativeField(stderr_handle, process_stderr, false);
     }
     if (mode == kNormal) {
-      Socket::SetSocketIdNativeField(exit_handle, exit_event);
+      Socket::SetSocketIdNativeField(exit_handle, exit_event, false);
     }
     Process::SetProcessIdNativeField(process, pid);
   } else {
     result =
         DartUtils::SetIntegerField(status_handle, "_errorCode", error_code);
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
     result = DartUtils::SetStringField(status_handle, "_errorMessage",
                                        os_error_message != NULL
                                            ? os_error_message
                                            : "Cannot get error message");
     if (Dart_IsError(result)) {
       Dart_PropagateError(result);
     }
   }
   Dart_SetReturnValue(args, Dart_NewBoolean(error_code == 0));
 }
 
 
 void FUNCTION_NAME(Process_Wait)(Dart_NativeArguments args) {
   Dart_Handle process = Dart_GetNativeArgument(args, 0);
-  intptr_t process_stdin =
+  Socket* process_stdin =
       Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 1));
-  intptr_t process_stdout =
+  Socket* process_stdout =
       Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 2));
-  intptr_t process_stderr =
+  Socket* process_stderr =
       Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 3));
-  intptr_t exit_event =
+  Socket* exit_event =
       Socket::GetSocketIdNativeField(Dart_GetNativeArgument(args, 4));
   ProcessResult result;
   intptr_t pid;
   Process::GetProcessIdNativeField(process, &pid);
-  if (Process::Wait(pid, process_stdin, process_stdout, process_stderr,
-                    exit_event, &result)) {
+  bool success = Process::Wait(pid, process_stdin->fd(), process_stdout->fd(),
+                               process_stderr->fd(), exit_event->fd(), &result);
+  // Process::Wait() closes the file handles, so blow away the fds in the
+  // Sockets so that they don't get picked up by the finalizer on _NativeSocket.
+  process_stdin->SetClosedFd();
+  process_stdout->SetClosedFd();
+  process_stderr->SetClosedFd();
+  exit_event->SetClosedFd();
+  if (success) {
     Dart_Handle out = result.stdout_data();
     if (Dart_IsError(out)) {
       Dart_PropagateError(out);
     }
     Dart_Handle err = result.stderr_data();
     if (Dart_IsError(err)) {
       Dart_PropagateError(err);
     }
     Dart_Handle list = Dart_NewList(4);
     Dart_ListSetAt(list, 0, Dart_NewInteger(pid));
@@ skipping 137 matching lines @@
   if (!Dart_IsError(external_array)) {
     memmove(buffer, system_string, system_len);
   }
   Dart_SetReturnValue(args, external_array);
 }
 
 }  // namespace bin
 }  // namespace dart
 
 #endif  // !defined(DART_IO_DISABLED)