Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm

Issue 2760283003: Update ContentSuggestions Articles UI (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm
diff --git a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm
index 7d5180e5f9f945ba81e306d35d4de833c28d43eb..bdb04fd3d5d7fe07b17a609f7133d216b3e83dd3 100644
--- a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm
+++ b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item.mm
@@ -18,7 +18,7 @@
namespace {
const CGFloat kImageSize = 72;
// When updating this, make sure to update |layoutSubviews|.
-const CGFloat kStandardSpacing = 8;
+const CGFloat kStandardSpacing = 16;
}
@interface ContentSuggestionsArticleItem ()
@@ -119,7 +119,7 @@ const CGFloat kStandardSpacing = 8;
_publisherLabel = [[UILabel alloc] initWithFrame:CGRectZero];
_titleLabel.numberOfLines = 2;
- _subtitleLabel.numberOfLines = 0;
+ _subtitleLabel.numberOfLines = 2;
[_subtitleLabel setContentHuggingPriority:UILayoutPriorityDefaultHigh
forAxis:UILayoutConstraintAxisVertical];
[_titleLabel setContentHuggingPriority:UILayoutPriorityDefaultHigh
@@ -187,6 +187,7 @@ const CGFloat kStandardSpacing = 8;
[NSLayoutConstraint activateConstraints:@[
[_imageView.widthAnchor constraintEqualToConstant:kImageSize],
[_imageView.heightAnchor constraintEqualToAnchor:_imageView.widthAnchor],
+ [_imageView.topAnchor constraintEqualToAnchor:_titleLabel.topAnchor],
[_publisherLabel.topAnchor
constraintGreaterThanOrEqualToAnchor:_imageView.bottomAnchor
constant:kStandardSpacing],
@@ -199,9 +200,8 @@ const CGFloat kStandardSpacing = 8;
@[
@"H:|-(space)-[title]-(space)-[image]-(space)-|",
@"H:|-(space)-[text]-(space)-[image]",
- @"V:|-[title]-[text]",
- @"V:|-[image]",
- @"H:|-[publish]-|",
+ @"V:|-(space)-[title]-[text]",
+ @"H:|-(space)-[publish]-(space)-|",
@"V:[publish]-|",
],
@{
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698