memory-infra: Fill the memory dump callback result (1/2)

base/trace_event/memory_allocator_dump.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TRACE_EVENT_MEMORY_ALLOCATOR_DUMP_H_
 #define BASE_TRACE_EVENT_MEMORY_ALLOCATOR_DUMP_H_
 
 #include <stdint.h>
 
 #include <memory>
 #include <string>
 
 #include "base/base_export.h"
+#include "base/gtest_prod_util.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/trace_event/memory_allocator_dump_guid.h"
 #include "base/values.h"
 
 namespace base {
 namespace trace_event {
 
 class ProcessMemoryDump;
 class TracedValue;
@@ skipping 54 matching lines @@
   // within the scope of a global dump. It is only required when using the
   // graph APIs (see TODO_method_name) to express retention / suballocation or
   // cross process sharing. See crbug.com/492102 for design docs.
   // Subsequent MemoryAllocatorDump(s) with the same |absolute_name| are
   // expected to have the same guid.
   const MemoryAllocatorDumpGuid& guid() const { return guid_; }
 
   TracedValue* attributes_for_testing() const { return attributes_.get(); }
 
  private:
+  // TODO(hjd): Transitional until we send the full PMD. See crbug.com/704203
+  friend class MemoryDumpManager;
+  FRIEND_TEST_ALL_PREFIXES(MemoryAllocatorDumpTest, GetSize);
+
   const std::string absolute_name_;
   ProcessMemoryDump* const process_memory_dump_;  // Not owned (PMD owns this).
   std::unique_ptr<TracedValue> attributes_;
   MemoryAllocatorDumpGuid guid_;
   int flags_;  // See enum Flags.
+  uint64_t size_;
+
+  // Get the size for this dump.
+  // The size is the value set with AddScalar(kNameSize, kUnitsBytes, size);
+  // TODO(hjd): Transitional until we send the full PMD. See crbug.com/704203
+  uint64_t GetSize();

[Primiano Tucci (use gerrit), 2017/03/24 11:39:21]

ups sorry just realized this, two small nits:
1. functions should go above fields, so this should go before absolute name.
2. +const
3. trivial accessors can be just inlined in small case, so this could be just be
just

uint64_6 get_size() const { return size_; }

[hjd, 2017/03/24 11:57:16]

Thanks, done!

 
   // A local buffer for Sprintf conversion on fastpath. Avoids allocating
   // temporary strings on each AddScalar() call.
   std::string string_conversion_buffer_;
 
   DISALLOW_COPY_AND_ASSIGN(MemoryAllocatorDump);
 };
 
 }  // namespace trace_event
 }  // namespace base
 
 #endif  // BASE_TRACE_EVENT_MEMORY_ALLOCATOR_DUMP_H_