Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: src/isolate.cc

Issue 2760233005: [snapshot] Move builtins generation into mksnapshot (Closed)
Patch Set: fix GYP builds Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/isolate.h ('k') | src/setup-isolate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/isolate.cc
diff --git a/src/isolate.cc b/src/isolate.cc
index 917349ba7dbbeb576417c330758fcdf927c45fbb..df52c0505278bef14132215406bcd75ba6270163 100644
--- a/src/isolate.cc
+++ b/src/isolate.cc
@@ -44,6 +44,7 @@
#include "src/prototype.h"
#include "src/regexp/regexp-stack.h"
#include "src/runtime-profiler.h"
+#include "src/setup-isolate.h"
#include "src/simulator.h"
#include "src/snapshot/deserializer.h"
#include "src/tracing/tracing-category-observer.h"
@@ -2247,6 +2248,7 @@ Isolate::Isolate(bool enable_serializer)
global_handles_(NULL),
eternal_handles_(NULL),
thread_manager_(NULL),
+ setup_delegate_(NULL),
regexp_stack_(NULL),
date_cache_(NULL),
call_descriptor_data_(NULL),
@@ -2686,7 +2688,10 @@ bool Isolate::Init(Deserializer* des) {
InitializeThreadLocal();
bootstrapper_->Initialize(create_heap_objects);
- builtins_.SetUp(this, create_heap_objects);
+ if (setup_delegate_ == nullptr) {
+ setup_delegate_ = new SetupIsolateDelegate();
+ }
+ setup_delegate_->SetupBuiltins(this, create_heap_objects);
if (create_heap_objects) heap_.CreateFixedStubs();
if (FLAG_log_internal_timer_events) {
@@ -2713,10 +2718,12 @@ bool Isolate::Init(Deserializer* des) {
}
load_stub_cache_->Initialize();
store_stub_cache_->Initialize();
- interpreter_->Initialize();
+ setup_delegate_->SetupInterpreter(interpreter_, create_heap_objects);
heap_.NotifyDeserializationComplete();
}
+ delete setup_delegate_;
+ setup_delegate_ = nullptr;
// Finish initialization of ThreadLocal after deserialization is done.
clear_pending_exception();
« no previous file with comments | « src/isolate.h ('k') | src/setup-isolate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698