[snapshot] Move builtins generation into mksnapshot

src/interpreter/interpreter.cc

Index: src/interpreter/interpreter.cc
diff --git a/src/interpreter/interpreter.cc b/src/interpreter/interpreter.cc
index c63e1e41372657125dfd15243bc87e3d0cee384b..87b1976ac79b03ca91ff9556a66102b796cc17cd 100644
--- a/src/interpreter/interpreter.cc
+++ b/src/interpreter/interpreter.cc
@@ -13,7 +13,6 @@
 #include "src/counters.h"
 #include "src/interpreter/bytecode-generator.h"
 #include "src/interpreter/bytecodes.h"
-#include "src/interpreter/interpreter-generator.h"
 #include "src/log.h"
 #include "src/objects.h"
 
@@ -75,45 +74,6 @@ Interpreter::Interpreter(Isolate* isolate) : isolate_(isolate) {
   memset(dispatch_table_, 0, sizeof(dispatch_table_));
 }
 
-void Interpreter::Initialize() {

[Jakob Kummerow, 2017/03/21 16:38:00]

This moved to setup-interpreter-full.cc.

-  if (!ShouldInitializeDispatchTable()) return;
-  HandleScope scope(isolate_);
-
-  if (FLAG_trace_ignition_dispatches) {
-    static const int kBytecodeCount = static_cast<int>(Bytecode::kLast) + 1;
-    bytecode_dispatch_counters_table_.reset(
-        new uintptr_t[kBytecodeCount * kBytecodeCount]);
-    memset(bytecode_dispatch_counters_table_.get(), 0,
-           sizeof(uintptr_t) * kBytecodeCount * kBytecodeCount);
-  }
-
-  // Generate bytecode handlers for all bytecodes and scales.
-  const OperandScale kOperandScales[] = {
-#define VALUE(Name, _) OperandScale::k##Name,
-      OPERAND_SCALE_LIST(VALUE)
-#undef VALUE
-  };
-
-  for (OperandScale operand_scale : kOperandScales) {
-#define GENERATE_CODE(Name, ...) \
-  InstallBytecodeHandler(isolate_, Bytecode::k##Name, operand_scale);
-    BYTECODE_LIST(GENERATE_CODE)
-#undef GENERATE_CODE
-  }
-
-  // Fill unused entries will the illegal bytecode handler.
-  size_t illegal_index =
-      GetDispatchTableIndex(Bytecode::kIllegal, OperandScale::kSingle);
-  for (size_t index = 0; index < arraysize(dispatch_table_); ++index) {
-    if (dispatch_table_[index] == nullptr) {
-      dispatch_table_[index] = dispatch_table_[illegal_index];
-    }
-  }
-
-  // Initialization should have been successful.
-  DCHECK(IsDispatchTableInitialized());
-}
-
 bool Interpreter::ReuseExistingHandler(Bytecode bytecode,
                                        OperandScale operand_scale) {
   size_t index = GetDispatchTableIndex(bytecode, operand_scale);
@@ -143,16 +103,6 @@ bool Interpreter::ReuseExistingHandler(Bytecode bytecode,
   }
 }
 
-void Interpreter::InstallBytecodeHandler(Isolate* isolate, Bytecode bytecode,
-                                         OperandScale operand_scale) {
-  if (!Bytecodes::BytecodeHasHandler(bytecode, operand_scale)) return;
-  if (ReuseExistingHandler(bytecode, operand_scale)) return;
-
-  size_t index = GetDispatchTableIndex(bytecode, operand_scale);
-  Handle<Code> code = GenerateBytecodeHandler(isolate, bytecode, operand_scale);
-  dispatch_table_[index] = code->entry();
-}
-
 Code* Interpreter::GetBytecodeHandler(Bytecode bytecode,
                                       OperandScale operand_scale) {
   DCHECK(IsDispatchTableInitialized());
@@ -285,16 +235,6 @@ bool Interpreter::IsDispatchTableInitialized() {
   return dispatch_table_[0] != nullptr;
 }
 
-bool Interpreter::ShouldInitializeDispatchTable() {
-  if (FLAG_trace_ignition || FLAG_trace_ignition_codegen ||
-      FLAG_trace_ignition_dispatches) {
-    // Regenerate table to add bytecode tracing operations, print the assembly
-    // code generated by TurboFan or instrument handlers with dispatch counters.
-    return true;
-  }
-  return !IsDispatchTableInitialized();
-}
-
 const char* Interpreter::LookupNameOfBytecodeHandler(Code* code) {
 #ifdef ENABLE_DISASSEMBLER
 #define RETURN_NAME(Name, ...)                                 \