Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: BUILD.gn

Issue 2760233005: [snapshot] Move builtins generation into mksnapshot (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gypfiles/features.gypi » ('j') | src/builtins/builtins.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 65a855f3e4f7a63bcb546a984d1ae89cde8f41b1..b9d3e770c4d17cee04e6d06e17ced5e6c495a569 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -810,6 +810,7 @@ source_set("v8_maybe_snapshot") {
} else {
# Ignore v8_use_external_startup_data setting if no snapshot is used.
public_deps = [
+ ":v8_builtins_setup",
":v8_nosnapshot",
]
}
@@ -823,7 +824,6 @@ v8_source_set("v8_nosnapshot") {
":js2c_experimental_extras",
":js2c_extras",
":v8_base",
- ":v8_builtins_generators",
]
sources = [
@@ -849,7 +849,6 @@ v8_source_set("v8_snapshot") {
":js2c_experimental_extras",
":js2c_extras",
":v8_base",
- ":v8_builtins_generators",
]
public_deps = [
# This should be public so downstream targets can declare the snapshot
@@ -862,6 +861,8 @@ v8_source_set("v8_snapshot") {
"$target_gen_dir/extras-libraries.cc",
"$target_gen_dir/libraries.cc",
"$target_gen_dir/snapshot.cc",
+ "src/builtins/setup-builtins-deserialize.cc",
+ "src/interpreter/setup-interpreter-deserialize.cc",
]
configs = [ ":internal_config" ]
@@ -876,7 +877,6 @@ if (v8_use_external_startup_data) {
":js2c_experimental_extras",
":js2c_extras",
":v8_base",
- ":v8_builtins_generators",
]
public_deps = [
":natives_blob",
@@ -884,6 +884,8 @@ if (v8_use_external_startup_data) {
]
sources = [
+ "src/builtins/setup-builtins-deserialize.cc",
+ "src/interpreter/setup-interpreter-deserialize.cc",
"src/snapshot/natives-external.cc",
"src/snapshot/snapshot-external.cc",
]
@@ -893,7 +895,11 @@ if (v8_use_external_startup_data) {
}
v8_source_set("v8_builtins_generators") {
- visibility = [ ":*" ] # Only targets in this file can depend on this.
+ visibility = [
+ ":*",
+ "../../test/cctest:*",
+ "../../test/unittests:*",
+ ]
deps = [
":v8_base",
@@ -909,6 +915,7 @@ v8_source_set("v8_builtins_generators") {
"src/builtins/builtins-async-gen.h",
"src/builtins/builtins-async-iterator-gen.cc",
"src/builtins/builtins-boolean-gen.cc",
+ "src/builtins/builtins-call-gen.cc",
"src/builtins/builtins-constructor-gen.cc",
"src/builtins/builtins-constructor-gen.h",
"src/builtins/builtins-constructor.h",
@@ -922,6 +929,7 @@ v8_source_set("v8_builtins_generators") {
"src/builtins/builtins-handler-gen.cc",
"src/builtins/builtins-ic-gen.cc",
"src/builtins/builtins-internal-gen.cc",
+ "src/builtins/builtins-interpreter-gen.cc",
"src/builtins/builtins-math-gen.cc",
"src/builtins/builtins-number-gen.cc",
"src/builtins/builtins-object-gen.cc",
@@ -935,6 +943,8 @@ v8_source_set("v8_builtins_generators") {
"src/builtins/builtins-typedarray-gen.cc",
"src/builtins/builtins-utils-gen.h",
"src/builtins/builtins-wasm-gen.cc",
+ "src/builtins/setup-builtins-internal.cc",
+ "src/builtins/setup-builtins.h",
"src/ic/accessor-assembler.cc",
"src/ic/accessor-assembler.h",
"src/ic/keyed-store-generic.cc",
@@ -997,6 +1007,21 @@ v8_source_set("v8_builtins_generators") {
configs = [ ":internal_config" ]
}
+v8_source_set("v8_builtins_setup") {
+ visibility = [ ":*" ] # Only targets in this file can depend on this.
+
+ deps = [
+ ":v8_builtins_generators",
+ ]
+
+ sources = [
+ "src/builtins/setup-builtins-full.cc",
+ "src/interpreter/setup-interpreter-full.cc",
+ ]
+
+ configs = [ ":internal_config" ]
+}
+
# This is split out to be a non-code containing target that the Chromium browser
# DLL can depend upon to get only a version string.
v8_header_set("v8_version") {
@@ -1127,6 +1152,7 @@ v8_source_set("v8_base") {
"src/builtins/builtins-utils.h",
"src/builtins/builtins.cc",
"src/builtins/builtins.h",
+ "src/builtins/setup-builtins.h",
"src/cached-powers.cc",
"src/cached-powers.h",
"src/callable.h",
@@ -2595,6 +2621,7 @@ if (current_toolchain == v8_snapshot_toolchain) {
deps = [
":v8_base",
+ ":v8_builtins_setup",
":v8_libbase",
":v8_libplatform",
":v8_nosnapshot",
« no previous file with comments | « no previous file | gypfiles/features.gypi » ('j') | src/builtins/builtins.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698