Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(164)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/cctest/setup-builtins-for-tests.cc
Issue
2760233005
:
[snapshot] Move builtins generation into mksnapshot (Closed)
Patch Set:
Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
BUILD.gn
gypfiles/features.gypi
src/builtins/builtins.h
src/builtins/builtins.cc
src/builtins/builtins-call.cc
src/builtins/builtins-call-gen.cc
src/builtins/builtins-interpreter.cc
src/builtins/builtins-interpreter-gen.cc
src/builtins/setup-builtins.h
src/builtins/setup-builtins-deserialize.cc
src/builtins/setup-builtins-full.cc
src/builtins/setup-builtins-internal.cc
src/interpreter/interpreter.h
src/interpreter/interpreter.cc
src/interpreter/setup-interpreter-deserialize.cc
src/interpreter/setup-interpreter-full.cc
src/isolate.h
src/isolate.cc
src/v8.gyp
test/cctest/BUILD.gn
test/cctest/cctest.gyp
test/cctest/setup-builtins-for-tests.h
test/cctest/setup-builtins-for-tests.cc
test/cctest/test-serialize.cc
test/unittests/BUILD.gn
tools/verify_source_deps.py
View unified diff
|
Download patch
« src/isolate.h
('K') |
« test/cctest/setup-builtins-for-tests.h
('k') |
test/cctest/test-serialize.cc »
('j') |
tools/verify_source_deps.py »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2017 the V8 project authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
#include "test/cctest/setup-builtins-for-tests.h"
6
7
namespace v8 {
8
namespace internal {
9
10
void SetupBuiltinsDelegateForTests::SetupBuiltins(Isolate* isolate,
11
bool create_heap_objects) {
12
if (create_heap_objects) {
13
SetupBuiltinsInternal(isolate);
14
}
15
}
16
17
} // namespace internal
18
} // namespace v8
OLD
NEW
« src/isolate.h
('K') |
« test/cctest/setup-builtins-for-tests.h
('k') |
test/cctest/test-serialize.cc »
('j') |
tools/verify_source_deps.py »
('J')
Issue 2760233005: [snapshot] Move builtins generation into mksnapshot (Closed)
Created 3 years, 9 months ago by Jakob Kummerow
Modified 3 years, 8 months ago
Reviewers: jgruber, rmcilroy, Michael Achenbach
Base URL:
Comments: 10
This is Rietveld
408576698
Chromium Code Reviews
Issue 2760233005:
[snapshot] Move builtins generation into mksnapshot (Closed)
