Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 276023002: Add more background js file and remove Google Analytics setup. (Closed)

Created:
6 years, 7 months ago by andycai1
Modified:
6 years, 6 months ago
Reviewers:
gauravsh
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add more background js file and remove Google Analytics setup. BUG=chromium:369679 TEST=Tested manually on daisy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269624

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/chromeos/echo/manifest.json View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
andycai1
I just seperate this CL from CL https://codereview.chromium.org/278433005/ Thanks.
6 years, 7 months ago (2014-05-09 18:34:28 UTC) #1
gauravsh
lgtm
6 years, 7 months ago (2014-05-09 18:39:20 UTC) #2
andycai1
The CQ bit was checked by andycai@chromium.org
6 years, 7 months ago (2014-05-09 18:53:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/andycai@chromium.org/276023002/1
6 years, 7 months ago (2014-05-09 18:56:53 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-10 19:57:17 UTC) #5
Message was sent while issue was closed.
Change committed as 269624

Powered by Google App Engine
This is Rietveld 408576698