Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(526)

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

Issue 2760183002: [MD setting] separate RawSiteException and SiteException (Closed)
Patch Set: more types Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_settings_behavior.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
diff --git a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
index 651257799ea56235bdc92ae0301a28b2e7da055e..34efa2cc0b7f3322a486e8ca770fb0adeb6a2cb6 100644
--- a/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
+++ b/chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js
@@ -19,6 +19,8 @@ var ContentSettingProvider = {
};
/**
+ * The site exception information passed form the C++ handler.
+ * See also: SiteException.
* @typedef {{embeddingOrigin: string,
* embeddingDisplayName: string,
* incognito: boolean,
@@ -27,6 +29,20 @@ var ContentSettingProvider = {
* setting: string,
* source: string}}
*/
+var RawSiteException;
+
+/**
+ * The site exception after it has been converted/filtered for UI use.
+ * See also: RawSiteException.
+ * @typedef {{category: !settings.ContentSettingsTypes,
+ * embeddingOrigin: string,
+ * embeddingDisplayName: string,
+ * incognito: boolean,
+ * origin: string,
+ * displayName: string,
+ * setting: string,
+ * source: string}}
+ */
var SiteException;
/**
@@ -120,14 +136,14 @@ cr.define('settings', function() {
/**
* Gets the exceptions (site list) for a particular category.
* @param {string} contentType The name of the category to query.
- * @return {!Promise<!Array<!SiteException>>}
+ * @return {!Promise<!Array<!RawSiteException>>}
*/
getExceptionList: function(contentType) {},
/**
* Gets the exception details for a particular site.
* @param {string} site The name of the site.
- * @return {!Promise<!SiteException>}
+ * @return {!Promise<!RawSiteException>}
*/
getSiteDetails: function(site) {},
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_settings_behavior.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698