[MD setting] separate RawSiteException and SiteException

chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview A helper object used from the "Site Settings" section to
  * interact with the content settings prefs.
  */
 
 /**
  * The handler will send a policy source that is similar, but not exactly the
  * same as a ControlledBy value. If the ContentSettingProvider is omitted it
  * should be treated as 'default'.
  * @enum {string}
  */
 var ContentSettingProvider = {
   EXTENSION: 'extension',
   PREFERENCE: 'preference',
 };
 
 /**
+ * The site exception information passed form the C++ handler.
+ * See also: SiteException.
  * @typedef {{embeddingOrigin: string,
  *            embeddingDisplayName: string,
  *            incognito: boolean,
  *            origin: string,
  *            displayName: string,
  *            setting: string,
  *            source: string}}
  */
+var RawSiteException;
+
+/**
+ * The site exception after it has been converted/filtered for UI use.
+ * See also: RawSiteException.
+ * @typedef {{category: string,

[dpapad, 2017/03/21 01:04:22]

Follow up question from previous comment.

1) Should this be
category: settings.ContentSettingsTypes
2) Should this type be moved to site_settings/constants.js? It is not used
anywhere in the proxy anymore (see related following comment too).

[dschuyler, 2017/03/22 01:35:41]

It can be. Done.
That's a reasonable idea. I'd like to keep this Cl relatively small since it's
just a cleanup/enhancement.

+ *            embeddingOrigin: string,
+ *            embeddingDisplayName: string,
+ *            incognito: boolean,
+ *            origin: string,
+ *            displayName: string,
+ *            setting: string,
+ *            source: string}}
+ */
 var SiteException;
 
 /**
  * @typedef {{location: string,
  *            notifications: string}}
  */
 var CategoryDefaultsPref;
 
 /**
  * @typedef {{setting: string,
  *            source: ContentSettingProvider}}
  */
 var DefaultContentSetting;
 
 /**
  * @typedef {{location: Array<SiteException>,

[dpapad, 2017/03/21 01:04:22]

What about these two?

[dschuyler, 2017/03/22 01:35:41]

Are ya asking if these should be RawSiteExceptions? I believe these are
correctly SiteExceptions. And, they could probably be moved elsewhere as well.
It's used in SiteSettingsPref, which in turn is used (maybe only) in unit tests.

[dpapad, 2017/03/22 17:28:53]

Ok. Yes, that is what I was asking.

  *            notifications: Array<SiteException>}}
  */
 var ExceptionListPref;
 
 /**
  * @typedef {{defaults: CategoryDefaultsPref,
  *            exceptions: ExceptionListPref}}
  */
 var SiteSettingsPref;
 
@@ skipping 57 matching lines @@
     /**
      * Gets the default value for a site settings category.
      * @param {string} contentType The name of the category to query.
      * @return {!Promise<!DefaultContentSetting>}
      */
     getDefaultValueForContentType: function(contentType) {},
 
     /**
      * Gets the exceptions (site list) for a particular category.
      * @param {string} contentType The name of the category to query.
-     * @return {!Promise<!Array<!SiteException>>}
+     * @return {!Promise<!Array<!RawSiteException>>}
      */
     getExceptionList: function(contentType) {},
 
     /**
      * Gets the exception details for a particular site.
      * @param {string} site The name of the site.
-     * @return {!Promise<!SiteException>}
+     * @return {!Promise<!RawSiteException>}
      */
     getSiteDetails: function(site) {},
 
     /**
      * Resets the category permission for a given origin (expressed as primary
      *    and secondary patterns).
      * @param {string} primaryPattern The origin to change (primary pattern).
      * @param {string} secondaryPattern The embedding origin to change
      *    (secondary pattern).
      * @param {string} contentType The name of the category to reset.
@@ skipping 275 matching lines @@
     removeZoomLevel: function(host) {
       chrome.send('removeZoomLevel', [host]);
     },
   };
 
   return {
     SiteSettingsPrefsBrowserProxy: SiteSettingsPrefsBrowserProxy,
     SiteSettingsPrefsBrowserProxyImpl: SiteSettingsPrefsBrowserProxyImpl,
   };
 });