content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc - Issue 2760163002: [IndexedDB] Pool and evict leveldb iterators, to save memory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

Issue 2760163002: [IndexedDB] Pool and evict leveldb iterators, to save memory (Closed)

Patch Set: comments & lifetime fix Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_backing_store.cc ('K') | « content/browser/indexed_db/indexed_db_class_factory.cc ('k') | content/browser/indexed_db/leveldb/leveldb_database.h » ('j') | content/browser/indexed_db/leveldb/leveldb_database.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

diff --git a/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc b/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

index 06d34197cf571d44c331b7052ee8f3f7ffa4dbde..add04decb3b9876207ac586a38c2b7c3113c908c 100644

--- a/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

+++ b/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

@@ -42,7 +42,8 @@ namespace {

class BustedLevelDBDatabase : public LevelDBDatabase {

public:

- BustedLevelDBDatabase() {}

+ BustedLevelDBDatabase()

+ : LevelDBDatabase(LevelDBDatabase::NO_CURSOR_EVICTION) {}

static std::unique_ptr<LevelDBDatabase> Open(

const base::FilePath& file_name,

const LevelDBComparator* /*comparator*/) {