Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Unified Diff: content/browser/indexed_db/leveldb/leveldb_transaction.h

Issue 2760163002: [IndexedDB] Pool and evict leveldb iterators, to save memory (Closed)
Patch Set: comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/leveldb/leveldb_transaction.h
diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.h b/content/browser/indexed_db/leveldb/leveldb_transaction.h
index a701a94748a6b02c10dcfdbd4f947084fa0f2a8f..bb54f70baab1a058bfb68d19b6a5f7285071e033 100644
--- a/content/browser/indexed_db/leveldb/leveldb_transaction.h
+++ b/content/browser/indexed_db/leveldb/leveldb_transaction.h
@@ -19,8 +19,6 @@
#include "content/browser/indexed_db/leveldb/leveldb_iterator.h"
namespace content {
-
-class LevelDBTransactionRangeTest;
class LevelDBWriteBatch;
class CONTENT_EXPORT LevelDBTransaction
@@ -49,7 +47,8 @@ class CONTENT_EXPORT LevelDBTransaction
private:
friend class base::RefCounted<LevelDBTransaction>;
- friend class content::LevelDBTransactionRangeTest;
+ friend class LevelDBTransactionRangeTest;
+ friend class LevelDBTransactionTest;
FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest, GetAndPut);
FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest, Commit);
FRIEND_TEST_ALL_PREFIXES(LevelDBTransactionTest, Iterator);
@@ -123,6 +122,7 @@ class CONTENT_EXPORT LevelDBTransaction
leveldb::Status Prev() override;
base::StringPiece Key() const override;
base::StringPiece Value() const override;
+ bool IsEvicted() const override;
jsbell 2017/03/23 21:48:21 Is this just for tests?
dmurph 2017/03/23 22:48:47 Yes.
void DataChanged();
// Mark the current record as deleted. If an existing record

Powered by Google App Engine
This is Rietveld 408576698