Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(238)

Issue 276011: [v8] Check for availablity of the media engine (Closed)

Created:
11 years ago by Alpha Left Google
Modified:
9 years, 4 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

[v8] Check for availablity of the media engine BUG=22837 Check for availablity of media engine so typeof(HTMLMediaElement) and friends can return undefined when media engine is not available.

Patch Set 1 : only diffs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M third_party/WebKit/WebCore/bindings/v8/custom/V8CustomBinding.h View 1 chunk +4 lines, -0 lines 1 comment Download
M third_party/WebKit/WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp View 1 chunk +20 lines, -0 lines 0 comments Download
M third_party/WebKit/WebCore/page/DOMWindow.idl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Alpha Left Google
submitting this for review just for sake of record.
11 years ago (2009-10-13 22:53:29 UTC) #1
Alpha Left Google
the double diff is because i'm submitting this change from git and manually add the ...
11 years ago (2009-10-13 22:59:29 UTC) #2
scherkus (not reviewing)
LGTM
11 years ago (2009-10-14 00:09:19 UTC) #3
Alpha Left Google
Please take a look again taking comments from atwilson.
11 years ago (2009-10-15 23:30:25 UTC) #4
scherkus (not reviewing)
http://codereview.chromium.org/276011/diff/4001/5001 File third_party/WebKit/WebCore/bindings/v8/custom/V8CustomBinding.h (right): http://codereview.chromium.org/276011/diff/4001/5001#newcode260 Line 260: DECLARE_ACCESSOR_RUNTIME_ENABLER(DOMWindowMediaError); might also have to do runtime enabling ...
11 years ago (2009-10-15 23:54:52 UTC) #5
Alpha Left Google
typeof(TimeRanges) should nothing for me..
11 years ago (2009-10-16 00:22:07 UTC) #6
Alpha Left Google
I mean it gives me "undefined" even in normal case.
11 years ago (2009-10-16 00:26:27 UTC) #7
scherkus (not reviewing)
11 years ago (2009-10-16 00:38:17 UTC) #8
LGTM
Was just wondering because of
http://www.whatwg.org/specs/web-apps/current-work/#timeranges

On Thu, Oct 15, 2009 at 5:26 PM, <hclam@chromium.org> wrote:

> I mean it gives me "undefined" even in normal case.
>
>
> http://codereview.chromium.org/276011
>

Powered by Google App Engine
This is Rietveld 408576698